8304147: JVM crash during shutdown when dumping dynamic archive

[dholmes-ora]

DynamicArchive::prepare_for_dump_at_exit() could be called concurrently on the two VM exit paths, leading either to assertion failures in debug builds, or a crash in product build when the actual dump occurred. The basic fix was to move the DynamicArchive::prepare_for_dump_at_exit() functionality into before_exit (java.cpp) where it can only be executed by one thread - thus avoiding the race (Phase 1).

Once that is done we can move the actual dump operation to be co-located with the prepare_for_dump_at_exit() (Phase 2) and then consolidate that code by refactoring it into a new DynamicArchive::dump_at_exit() method (Phase 3), and then removing the leftover methods that are no longer needed (Phase 4).

Each phase can be seen in distinct commits if you prefer to see the steps involved.

Testing:

• new ExitRace test
• all dynamicArchive tests
• tiers 1-4

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304147: JVM crash during shutdown when dumping dynamic archive

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer) ⚠️ Review applies to 518f5409
• Matias Saavedra Silva (@matias9927 - Committer) ⚠️ Review applies to 518f5409
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13134/head:pull/13134
$ git checkout pull/13134

Update a local copy of the PR:
$ git checkout pull/13134
$ git pull https://git.openjdk.org/jdk.git pull/13134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13134

View PR using the GUI difftool:
$ git pr show -t 13134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13134.diff

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @dholmes-ora This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dholmes-ora]

/issue 8304147
/label add hotspot-runtime
/label remove hotspot

[openjdk]

@dholmes-ora This issue is referenced in the PR title - it will now be updated.

[openjdk]

@dholmes-ora
The hotspot-runtime label was successfully added.

[openjdk]

@dholmes-ora
The hotspot label was successfully removed.

[mlbridge]

Webrevs

• 02: Full - Incremental (f037df96)
• 01: Full - Incremental (518f5409)
• 00: Full (d0d0d5d1)

[calvinccheung]

Thanks for fixing this. I've couple of comments.

[dholmes-ora]

Thanks for looking at this @calvinccheung !

[calvinccheung]

Updates look good.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304147: JVM crash during shutdown when dumping dynamic archive

Reviewed-by: ccheung, matsaave, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

• 3b88b2a: 8304761: Update IANA Language Subtag Registry to Version 2023-03-22
• f8e8fc7: 8177352: Calendar.getDisplayName(s) in non-lenient mode inconsistent, does not match spec
• 14b970d: 8296656: java.lang.NoClassDefFoundError exception on running fully legitimate code
• 80e2d52: 8302558: Editable JComboBox's popup blocks user from seeing characters in Aqua look and feel
• 6c3b10f: 8303485: Replacing os.name for operating system customization
• 87b314a: 7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color
• 2f34687: 8304689: Add hidden option to disable external spec page
• 6b2f34f: 8304718: GetIntArrayElements should not be passed JNI_FALSE
• 138cdc9: 8304694: Runtime exception thrown when break stmt is missing
• 46b0602: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
• ... and 52 more: https://git.openjdk.org/jdk/compare/c039d26603e85ae37b0a53430a47f5751bf911af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[matias9927]

Consolidating some of the simpler methods is a good idea! LGTM

[coleenp]

This is a very nice simplification of the JVM exit paths. I had a few minor comments.

[dholmes-ora]

Thanks for the review @matias9927 !

[dholmes-ora]

Thanks for the review @coleenp - all comments now addressed.

[dholmes-ora]

/integrate

[openjdk]

Going to push as commit 63ce88b.
Since your change was applied there have been 63 commits pushed to the master branch:

• 554bccf: 8304448: Kitchensink failed: assert(!thread->is_in_any_VTMS_transition()) failed: class prepare events are not allowed in any VTMS transition
• 3b88b2a: 8304761: Update IANA Language Subtag Registry to Version 2023-03-22
• f8e8fc7: 8177352: Calendar.getDisplayName(s) in non-lenient mode inconsistent, does not match spec
• 14b970d: 8296656: java.lang.NoClassDefFoundError exception on running fully legitimate code
• 80e2d52: 8302558: Editable JComboBox's popup blocks user from seeing characters in Aqua look and feel
• 6c3b10f: 8303485: Replacing os.name for operating system customization
• 87b314a: 7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color
• 2f34687: 8304689: Add hidden option to disable external spec page
• 6b2f34f: 8304718: GetIntArrayElements should not be passed JNI_FALSE
• 138cdc9: 8304694: Runtime exception thrown when break stmt is missing
• ... and 53 more: https://git.openjdk.org/jdk/compare/c039d26603e85ae37b0a53430a47f5751bf911af...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit 63ce88b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.