Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick #13136

Closed
wants to merge 8 commits into from

Conversation

afshin-zafari
Copy link
Contributor

@afshin-zafari afshin-zafari commented Mar 22, 2023

Only the instances of using union for converting int to float are replaced with call to PrimitiveConversions::cast<To>(From) method. Some few cases with conversion of long <->double are also replaced with PrimitiveConversions::cast<To>(From). The other instances where the union contains other types of fields than int and float are left unchanged.

Test

local hotspot:tier1
mach5 tiers 1-5


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13136/head:pull/13136
$ git checkout pull/13136

Update a local copy of the PR:
$ git checkout pull/13136
$ git pull https://git.openjdk.org/jdk.git pull/13136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13136

View PR using the GUI difftool:
$ git pr show -t 13136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13136.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2023

👋 Welcome back afshin-zafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2023

@afshin-zafari The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 22, 2023
@afshin-zafari afshin-zafari marked this pull request as ready for review March 27, 2023 12:38
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 27, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2023

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are a couple of minor include file ordering things to fix.

src/hotspot/cpu/aarch64/assembler_aarch64.cpp Outdated Show resolved Hide resolved
src/hotspot/cpu/aarch64/immediate_aarch64.cpp Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Mar 27, 2023

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick

Reviewed-by: coleenp, kbarrett, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 158 new commits pushed to the master branch:

  • 8eb4e7e: 8277501: Revisit PathFileObject.getCharContent and friends
  • abfb900: 8304028: Port fdlibm IEEEremainder to Java
  • a565be4: 8297605: improve DelayQueue removal method javadoc
  • cccb019: 8304928: Optimize ClassDesc.resolveConstantDesc
  • bdbf8fc: 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value
  • 4a5d7ca: 8305227: [s390x] build broken after JDK-8231349
  • dae1ab3: 8304844: JFR: Missing disk parameter in ActiveRecording event
  • e012685: 8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized
  • fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
  • 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
  • ... and 148 more: https://git.openjdk.org/jdk/compare/ded6a8131970ac2f7ae59716769e6f6bae3b809a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp, @kimbarrett, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 27, 2023
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. Just a few minor nits and naming issues.

src/hotspot/cpu/aarch64/assembler_aarch64.cpp Outdated Show resolved Hide resolved
src/hotspot/cpu/arm/assembler_arm.hpp Outdated Show resolved Hide resolved
src/hotspot/cpu/arm/assembler_arm.hpp Outdated Show resolved Hide resolved
src/hotspot/cpu/arm/macroAssembler_arm.cpp Outdated Show resolved Hide resolved
src/hotspot/share/runtime/sharedRuntime.cpp Outdated Show resolved Hide resolved
src/hotspot/cpu/arm/assembler_arm.hpp Outdated Show resolved Hide resolved
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay other than the override issue.

Thanks.

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@afshin-zafari
Copy link
Contributor Author

Thank you Coleen, Kim and David for your comments and reviews.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 31, 2023
@openjdk
Copy link

openjdk bot commented Mar 31, 2023

@afshin-zafari
Your change (at version cc36b50) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 1, 2023

Going to push as commit a19b28a.
Since your change was applied there have been 158 commits pushed to the master branch:

  • 8eb4e7e: 8277501: Revisit PathFileObject.getCharContent and friends
  • abfb900: 8304028: Port fdlibm IEEEremainder to Java
  • a565be4: 8297605: improve DelayQueue removal method javadoc
  • cccb019: 8304928: Optimize ClassDesc.resolveConstantDesc
  • bdbf8fc: 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value
  • 4a5d7ca: 8305227: [s390x] build broken after JDK-8231349
  • dae1ab3: 8304844: JFR: Missing disk parameter in ActiveRecording event
  • e012685: 8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized
  • fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
  • 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
  • ... and 148 more: https://git.openjdk.org/jdk/compare/ded6a8131970ac2f7ae59716769e6f6bae3b809a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2023
@openjdk openjdk bot closed this Apr 1, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 1, 2023
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 1, 2023
@openjdk
Copy link

openjdk bot commented Apr 1, 2023

@dholmes-ora @afshin-zafari Pushed as commit a19b28a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
4 participants