8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers

[lahodaj]

_ is a valid name for --release 8, but code that estimates if a piece of code is an enum constant or a member will fail to recognize that. This patch enhances the estimator to include _ at the same level as identifiers.

For the estimator, it is not important if _ is permitted for the given source level or not - the upper levels will produce proper errors/warnings. So, the estimator will consider _ to be at the same level as an ordinary identifier.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13137/head:pull/13137
$ git checkout pull/13137

Update a local copy of the PR:
$ git checkout pull/13137
$ git pull https://git.openjdk.org/jdk.git pull/13137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13137

View PR using the GUI difftool:
$ git pr show -t 13137

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13137.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (56ca9eb8)

[vicente-romero-oracle]

looks sensible

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers

Reviewed-by: vromero, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• a2d8f63: 8288730: Add type parameter to Lookup::accessClass and Lookup::ensureInitialized
• 3777455: 8302191: Performance degradation for float/double modulo on Linux
• 760c012: 8304683: Memory leak in WB_IsMethodCompatible
• 75168ea: 8304134: jib bootstrapper fails to quote filename when checking download filetype
• 4154a98: 8301498: Replace NULL with nullptr in cpu/x86
• ddf1e34: 8304089: Convert TraceDependencies to UL
• 358c61b: 8294972: Convert jdk.jlink internal plugins to use the Classfile API
• c74507e: 8304657: G1: Rename set_state_empty to set_state_untracked
• ca94287: 8304144: G1: Remove unnecessary is_survivor check in G1ClearCardTableTask
• eda0065: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659
• ... and 47 more: https://git.openjdk.org/jdk/compare/620564ac6152be92c5fa83b474d30a43e698d51e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

Thanks for tackling that so quickly.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 63d4afb.
Since your change was applied there have been 62 commits pushed to the master branch:

• e2cfcfb: 6817009: Action.SELECTED_KEY not toggled when using key binding
• af4d560: 8303951: Add asserts before record_method_not_compilable where possible
• c433862: 6245410: javax.swing.text.html.CSS.Attribute: BACKGROUND_POSITION is not w3c spec compliant
• 91f407d: 8029301: Confusing error message for array creation method reference
• e73411a: 8304376: Rename t1/t2 classes in com/sun/jdi/CLETest.java to avoid class duplication error in IDE
• a2d8f63: 8288730: Add type parameter to Lookup::accessClass and Lookup::ensureInitialized
• 3777455: 8302191: Performance degradation for float/double modulo on Linux
• 760c012: 8304683: Memory leak in WB_IsMethodCompatible
• 75168ea: 8304134: jib bootstrapper fails to quote filename when checking download filetype
• 4154a98: 8301498: Replace NULL with nullptr in cpu/x86
• ... and 52 more: https://git.openjdk.org/jdk/compare/620564ac6152be92c5fa83b474d30a43e698d51e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 63d4afb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.