8303508: Vector.lane() gets wrong value on x86

[jatin-bhateja]

Incorrectness happens because compiler absorbs casting IR chain during idealizations.
Sign extending the result of sub-word extraction operation.

Please refer to detailed discussion on #13070 (comment)

Best Regards,
Jatin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303508: Vector.lane() gets wrong value on x86

Reviewers

• Eric Liu (@theRealELiu - Committer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13152/head:pull/13152
$ git checkout pull/13152

Update a local copy of the PR:
$ git checkout pull/13152
$ git pull https://git.openjdk.org/jdk.git pull/13152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13152

View PR using the GUI difftool:
$ git pr show -t 13152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13152.diff

[bridgekeeper]

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[jatin-bhateja]

/label add hotspot-compiler

[openjdk]

@jatin-bhateja The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@jatin-bhateja The hotspot-compiler label was already applied.

[mlbridge]

Webrevs

• 00: Full (f672ad94)

[e1iu]

Looks good to me. Thanks for your fix.

[TobiHartmann]

Looks good. I submitted some testing and will report back once it finished.

[openjdk]

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303508: Vector.lane() gets wrong value on x86

Reviewed-by: eliu, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• c433862: 6245410: javax.swing.text.html.CSS.Attribute: BACKGROUND_POSITION is not w3c spec compliant
• 91f407d: 8029301: Confusing error message for array creation method reference
• e73411a: 8304376: Rename t1/t2 classes in com/sun/jdi/CLETest.java to avoid class duplication error in IDE
• a2d8f63: 8288730: Add type parameter to Lookup::accessClass and Lookup::ensureInitialized
• 3777455: 8302191: Performance degradation for float/double modulo on Linux
• 760c012: 8304683: Memory leak in WB_IsMethodCompatible
• 75168ea: 8304134: jib bootstrapper fails to quote filename when checking download filetype
• 4154a98: 8301498: Replace NULL with nullptr in cpu/x86
• ddf1e34: 8304089: Convert TraceDependencies to UL
• 358c61b: 8294972: Convert jdk.jlink internal plugins to use the Classfile API

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

All tests passed.

[jatin-bhateja]

/integrate

[openjdk]

Going to push as commit d61de14.
Since your change was applied there have been 29 commits pushed to the master branch:

• 941a7ac: 8304301: Remove the global option SuperWordMaxVectorSize
• ac6af6a: 7176515: ExceptionInInitializerError for an enum with multiple switch statements
• dd23ee9: 8303917: Update ISO 639 language codes table
• 6f67abd: 8304557: java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java times out
• 568dd57: 8304716: Clean up G1Policy::calc_max_old_cset_length()
• af0504e: 8304691: Remove jlink --post-process-path option
• 3859faf: 8231349: Move intrinsic stubs generation to compiler runtime initialization code
• f37674a: 8304711: Combine G1 root region abort and wait into a single method
• 7f9e691: 8304712: Only pass total number of regions into G1Policy::calc_min_old_cset_length
• 51035a7: 8294137: Review running times of java.math tests
• ... and 19 more: https://git.openjdk.org/jdk/compare/c74507eeb3c6b744b144e241373b109548624121...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jatin-bhateja Pushed as commit d61de14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.