Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8304761: Update IANA Language Subtag Registry to Version 2023-03-22 #13165

Closed
wants to merge 4 commits into from
Closed

8304761: Update IANA Language Subtag Registry to Version 2023-03-22 #13165

wants to merge 4 commits into from

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Mar 23, 2023 •
edited by openjdk bot
Loading

Update IANA LSR to 2023-03-22 update. Add all new preferred languages to ACCEPT_LANGUAGES except gu.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304761: Update IANA Language Subtag Registry to Version 2023-03-22

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13165/head:pull/13165
$ git checkout pull/13165

Update a local copy of the PR:
$ git checkout pull/13165
$ git pull https://git.openjdk.org/jdk.git pull/13165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13165

View PR using the GUI difftool:
$ git pr show -t 13165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13165.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2023
@openjdk
Copy link

openjdk bot commented Mar 23, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 23, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2023 •
edited
Loading

Webrevs

naotoj
naotoj reviewed Mar 23, 2023
View reviewed changes
test/jdk/java/util/Locale/LanguageSubtagRegistryTest.java Outdated
new LanguageRange("uss", 1.0),
new LanguageRange("uth", 1.0),
new LanguageRange("ysm", 1.0),
new LanguageRange("sgn-ysm", 1.0),
new LanguageRange("wkr", 0.9),
new LanguageRange("wkr", 1.0),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason the weight has changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wkr added into ACCEPT_LANGUAGES incorrectly by me, fixed now.

naotoj
naotoj approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Mar 24, 2023 •
edited
Loading

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304761: Update IANA Language Subtag Registry to Version 2023-03-22

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 310 new commits pushed to the master branch:

  • 80e2d52: 8302558: Editable JComboBox's popup blocks user from seeing characters in Aqua look and feel
  • 6c3b10f: 8303485: Replacing os.name for operating system customization
  • 87b314a: 7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color
  • 2f34687: 8304689: Add hidden option to disable external spec page
  • 6b2f34f: 8304718: GetIntArrayElements should not be passed JNI_FALSE
  • 138cdc9: 8304694: Runtime exception thrown when break stmt is missing
  • 46b0602: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
  • 8d423f7: 8304723: Statically allocate global mutexes
  • 2083088: 8304828: Lots of constant static data not declared static const in cpu/x86
  • 0712adc: 7169951: SwingSet2 throws NullPointerException with Nimbus L&F
  • ... and 300 more: https://git.openjdk.org/jdk/compare/f3abc4063de658418283aee1f552c4b4976e5211...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 24, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 27, 2023
@openjdk
Copy link

openjdk bot commented Mar 27, 2023

@justin-curtis-lu
Your change (at version ff7901f) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Mar 27, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 27, 2023

Going to push as commit 3b88b2a.
Since your change was applied there have been 312 commits pushed to the master branch:

  • f8e8fc7: 8177352: Calendar.getDisplayName(s) in non-lenient mode inconsistent, does not match spec
  • 14b970d: 8296656: java.lang.NoClassDefFoundError exception on running fully legitimate code
  • 80e2d52: 8302558: Editable JComboBox's popup blocks user from seeing characters in Aqua look and feel
  • 6c3b10f: 8303485: Replacing os.name for operating system customization
  • 87b314a: 7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color
  • 2f34687: 8304689: Add hidden option to disable external spec page
  • 6b2f34f: 8304718: GetIntArrayElements should not be passed JNI_FALSE
  • 138cdc9: 8304694: Runtime exception thrown when break stmt is missing
  • 46b0602: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
  • 8d423f7: 8304723: Statically allocate global mutexes
  • ... and 302 more: https://git.openjdk.org/jdk/compare/f3abc4063de658418283aee1f552c4b4976e5211...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2023
@openjdk openjdk bot closed this Mar 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 27, 2023
@openjdk
Copy link

openjdk bot commented Mar 27, 2023

@naotoj @justin-curtis-lu Pushed as commit 3b88b2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naotoj naotoj naotoj approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin-curtis-lu @naotoj