Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297977: vmTestbase/nsk/stress/except/except012.java fails with unexpected Exception #13169

Closed
wants to merge 2 commits into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Mar 23, 2023

These vmTestbase/nsk/stress/except tests all allocate enough memory to get an OutOfMemoryError then try to throw an exception for a variety of error conditions. The tests pass (or all say it's "Skipped ...") if that throws OutOfMemoryError, which all the tests do.
Only except001.java did something useful - called a function that gets OOM reflectively then tests that it got an InvocationTargetException so I moved that to runtime/reflect/ReflectOutOfMemoryError.java. This change removes the rest.

I couldn't reproduce the original failure in except012.java, which gets another exception (not OOM or ThreadDeath).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297977: vmTestbase/nsk/stress/except/except012.java fails with unexpected Exception

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13169/head:pull/13169
$ git checkout pull/13169

Update a local copy of the PR:
$ git checkout pull/13169
$ git pull https://git.openjdk.org/jdk.git pull/13169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13169

View PR using the GUI difftool:
$ git pr show -t 13169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13169.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2023

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2023
@openjdk
Copy link

openjdk bot commented Mar 23, 2023

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 23, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2023

Webrevs

Copy link
Member

@mseledts mseledts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you Coleen.

@openjdk
Copy link

openjdk bot commented Mar 23, 2023

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297977: vmTestbase/nsk/stress/except/except012.java fails with unexpected Exception

Reviewed-by: mseledtsov, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • ac6af6a: 7176515: ExceptionInInitializerError for an enum with multiple switch statements
  • dd23ee9: 8303917: Update ISO 639 language codes table
  • 6f67abd: 8304557: java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java times out
  • 568dd57: 8304716: Clean up G1Policy::calc_max_old_cset_length()
  • af0504e: 8304691: Remove jlink --post-process-path option
  • 3859faf: 8231349: Move intrinsic stubs generation to compiler runtime initialization code
  • f37674a: 8304711: Combine G1 root region abort and wait into a single method
  • 7f9e691: 8304712: Only pass total number of regions into G1Policy::calc_min_old_cset_length
  • 51035a7: 8294137: Review running times of java.math tests
  • 46cca1a: 4842457: (bf spec) Clarify meaning of "(optional operation)"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 23, 2023
@coleenp
Copy link
Contributor Author

coleenp commented Mar 23, 2023

/test
Why do GHA fail?

@lmesnik
Copy link
Member

lmesnik commented Mar 23, 2023

There is an infra issue downloading jtreg, I don't know who supports GHA actions.

@coleenp
Copy link
Contributor Author

coleenp commented Mar 24, 2023

Thanks Misha and Leonid. GHA seems to be happier now.
/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2023

Going to push as commit 4ec720d.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 13dd19a: 8304802: After JDK-8297639 the flag G1UsePreventiveGC needs to be added to the obsoletion table
  • d61de14: 8303508: Vector.lane() gets wrong value on x86
  • 941a7ac: 8304301: Remove the global option SuperWordMaxVectorSize
  • ac6af6a: 7176515: ExceptionInInitializerError for an enum with multiple switch statements
  • dd23ee9: 8303917: Update ISO 639 language codes table
  • 6f67abd: 8304557: java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java times out
  • 568dd57: 8304716: Clean up G1Policy::calc_max_old_cset_length()
  • af0504e: 8304691: Remove jlink --post-process-path option
  • 3859faf: 8231349: Move intrinsic stubs generation to compiler runtime initialization code
  • f37674a: 8304711: Combine G1 root region abort and wait into a single method
  • ... and 3 more: https://git.openjdk.org/jdk/compare/6fa25cc134e8a6787490e080fb98c2d61cf0b049...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2023
@openjdk openjdk bot closed this Mar 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2023
@openjdk
Copy link

openjdk bot commented Mar 24, 2023

@coleenp Pushed as commit 4ec720d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the except012 branch March 24, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants