-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297977: vmTestbase/nsk/stress/except/except012.java fails with unexpected Exception #13169
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you Coleen.
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/test |
There is an infra issue downloading jtreg, I don't know who supports GHA actions. |
Thanks Misha and Leonid. GHA seems to be happier now. |
Going to push as commit 4ec720d.
Your commit was automatically rebased without conflicts. |
These vmTestbase/nsk/stress/except tests all allocate enough memory to get an OutOfMemoryError then try to throw an exception for a variety of error conditions. The tests pass (or all say it's "Skipped ...") if that throws OutOfMemoryError, which all the tests do.
Only except001.java did something useful - called a function that gets OOM reflectively then tests that it got an InvocationTargetException so I moved that to runtime/reflect/ReflectOutOfMemoryError.java. This change removes the rest.
I couldn't reproduce the original failure in except012.java, which gets another exception (not OOM or ThreadDeath).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13169/head:pull/13169
$ git checkout pull/13169
Update a local copy of the PR:
$ git checkout pull/13169
$ git pull https://git.openjdk.org/jdk.git pull/13169/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13169
View PR using the GUI difftool:
$ git pr show -t 13169
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13169.diff