8304844 JFR: Missing disk parameter in ActiveRecording event

[egahlin]

Could I have a review of a change that adds the disk parameter to the ActiveRecording event.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304844: JFR: Missing disk parameter in ActiveRecording event

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13171/head:pull/13171
$ git checkout pull/13171

Update a local copy of the PR:
$ git checkout pull/13171
$ git pull https://git.openjdk.org/jdk.git pull/13171/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13171

View PR using the GUI difftool:
$ git pr show -t 13171

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13171.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fc3890c3)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304844: JFR: Missing disk parameter in ActiveRecording event

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• cddaf68: 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused
• a06f461: 8303214: Typo in java.util.Collections#synchronizedNavigableMap javadoc
• 7987ad4: 8304412: Serial: Refactor old generation cards update after Full GC
• 3c4cd50: 8304963: HttpServer closes connection after processing HEAD after JDK-7026262
• 4f625c0: 8304543: Modernize debugging jvm args in test/hotspot/jtreg/vmTestbase/nsk/jdi/Argument/value/value004.java
• 426025a: 8303526: Changing "arbitrary" Name.compareTo() ordering breaks the regression suite
• 6aec6f3: 8304931: vm/concepts/methods/methods001/methods00101m1/methods00101m1 failures with already pending exception
• 63ce88b: 8304147: JVM crash during shutdown when dumping dynamic archive
• 554bccf: 8304448: Kitchensink failed: assert(!thread->is_in_any_VTMS_transition()) failed: class prepare events are not allowed in any VTMS transition
• 3b88b2a: 8304761: Update IANA Language Subtag Registry to Version 2023-03-22
• ... and 30 more: https://git.openjdk.org/jdk/compare/ac6af6a64099c182e982a0a718bc1b780cef616e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit dae1ab3.
Since your change was applied there have been 95 commits pushed to the master branch:

• e012685: 8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized
• fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
• 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
• 049b953: 8305223: IGV: mark osr compiled graphs with [OSR] in the name
• 345669c: 8302738: IGV: refine 'Simplify graph' filter
• dea9db2: 8305055: IR check fails on some aarch64 platforms
• c8f3a97: 8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()
• 7fe5bd2: 8305174: disable dtrace for s390x builds
• 787832a: 8304988: unnecessary dash in @param gives double-dash in docs
• a144c71: 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp
• ... and 85 more: https://git.openjdk.org/jdk/compare/ac6af6a64099c182e982a0a718bc1b780cef616e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit dae1ab3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.