Skip to content

8304445: Remaining uses of NULL in ciInstanceKlass.cpp#13178

Closed
ikorennoy wants to merge 1 commit intoopenjdk:masterfrom
ikorennoy:8304445
Closed

8304445: Remaining uses of NULL in ciInstanceKlass.cpp#13178
ikorennoy wants to merge 1 commit intoopenjdk:masterfrom
ikorennoy:8304445

Conversation

@ikorennoy
Copy link
Contributor

@ikorennoy ikorennoy commented Mar 24, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304445: Remaining uses of NULL in ciInstanceKlass.cpp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13178/head:pull/13178
$ git checkout pull/13178

Update a local copy of the PR:
$ git checkout pull/13178
$ git pull https://git.openjdk.org/jdk.git pull/13178/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13178

View PR using the GUI difftool:
$ git pr show -t 13178

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13178.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2023

👋 Welcome back ikorennoy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 24, 2023

@ikorennoy The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review labels Mar 24, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 24, 2023

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Mar 30, 2023

@ikorennoy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304445: Remaining uses of NULL in ciInstanceKlass.cpp

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

  • 2c38e67: 8302644: IGV: Apply filters per graph tab and not globally
  • f0dba21: 8304871: Use default visibility for static library builds
  • 77811fa: 8305222: Change unique_ctrl_out_or_null to unique_ctrl_out in PhaseCFG::convert_NeverBranch_to_Goto
  • 2d607c9: 8262294: java/net/httpclient/ProxyAuthDisabledSchemes.java fails with HTTP/1.1 parser received no bytes
  • b3ff8d1: 8303805: [REDO] JDK-8302189 and JDK-8302799
  • b524a74: 8301106: Allow archived Java strings to be moved by GC
  • 9643f65: 8304436: com/sun/jdi/ThreadMemoryLeakTest.java fails with "OutOfMemoryError: Java heap space" with ZGC
  • 69152c3: 8305202: Fix Copyright Header in ZonedDateTimeFormatterBenchmark
  • 438c969: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()
  • d063b89: 8303392: Runtime.exec and ProcessBuilder.start should use System logger
  • ... and 61 more: https://git.openjdk.org/jdk/compare/9a8a60f7d6caae5b517b4284e10946ccc172ebd3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2023
@ikorennoy
Copy link
Contributor Author

@TobiHartmann thank you for the review!

@ikorennoy
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 30, 2023
@openjdk
Copy link

openjdk bot commented Mar 30, 2023

@ikorennoy
Your change (at version 4ee4df0) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 30, 2023

Going to push as commit b261e6c.
Since your change was applied there have been 71 commits pushed to the master branch:

  • 2c38e67: 8302644: IGV: Apply filters per graph tab and not globally
  • f0dba21: 8304871: Use default visibility for static library builds
  • 77811fa: 8305222: Change unique_ctrl_out_or_null to unique_ctrl_out in PhaseCFG::convert_NeverBranch_to_Goto
  • 2d607c9: 8262294: java/net/httpclient/ProxyAuthDisabledSchemes.java fails with HTTP/1.1 parser received no bytes
  • b3ff8d1: 8303805: [REDO] JDK-8302189 and JDK-8302799
  • b524a74: 8301106: Allow archived Java strings to be moved by GC
  • 9643f65: 8304436: com/sun/jdi/ThreadMemoryLeakTest.java fails with "OutOfMemoryError: Java heap space" with ZGC
  • 69152c3: 8305202: Fix Copyright Header in ZonedDateTimeFormatterBenchmark
  • 438c969: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()
  • d063b89: 8303392: Runtime.exec and ProcessBuilder.start should use System logger
  • ... and 61 more: https://git.openjdk.org/jdk/compare/9a8a60f7d6caae5b517b4284e10946ccc172ebd3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 30, 2023
@openjdk openjdk bot closed this Mar 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 30, 2023
@openjdk
Copy link

openjdk bot commented Mar 30, 2023

@TobiHartmann @ikorennoy Pushed as commit b261e6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ikorennoy ikorennoy deleted the 8304445 branch March 30, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants