8304927: Update java/net/httpclient/BasicAuthTest.java to check basic auth over HTTP/2

[dfuch]

The BasicAuthTest only tests basic authentication with clear HTTP/1.1.
This changes upgrades it to also test against TLS, as well as HTTP/2.
The bulk of the fix is to move the implementation of a HttpBasicAuthFilter from DigestEchoServer.java to HttpServerAdapters. This makes it possible to enable basic auth in the HTTP/2 test server.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304927: Update java/net/httpclient/BasicAuthTest.java to check basic auth over HTTP/2

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer) ⚠️ Review applies to 446b1b48

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13189/head:pull/13189
$ git checkout pull/13189

Update a local copy of the PR:
$ git checkout pull/13189
$ git pull https://git.openjdk.org/jdk.git pull/13189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13189

View PR using the GUI difftool:
$ git pr show -t 13189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13189.diff

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (968f1fb4)
• 00: Full (446b1b48)

[jaikiran]

Looks good to me.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304927: Update java/net/httpclient/BasicAuthTest.java to check basic auth over HTTP/2

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• c1f5ca1: 8303623: Compiler should disallow non-standard UTF-8 string encodings
• 695683b: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC
• 83ce65e: 8305004: add @SPEC tags to langtools modules
• 32ef452: 8304884: Update Bytecodes data to be mostly compile time constants
• 927e674: 8300977: Retire java.io.ExpiringCache
• c90699e: 8304989: unnecessary dash in @param gives double-dash in docs
• 395a4ce: 8304591: (fs) UnixPath.stringValue need not be volatile
• 60640a2: 8300979: Lazily initialize (byte, char)arr in java.io.DataInputStream
• cddaf68: 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused
• a06f461: 8303214: Typo in java.util.Collections#synchronizedNavigableMap javadoc
• ... and 25 more: https://git.openjdk.org/jdk/compare/38e17148faef7799515478bd834ed2fa1a5153de...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dfuch]

/integrate

[openjdk]

Going to push as commit 50a995f.
Since your change was applied there have been 39 commits pushed to the master branch:

• ca745cb: 8291598: Matcher.appendReplacement should not create new StringBuilder instances
• 1683a63: 8305098: [Backout] JDK-8303912 Clean up JavadocTokenizer
• fab2357: 8304498: JShell does not switch to raw mode when there is no /bin/test
• 1fc218c: 8303912: Clean up JavadocTokenizer
• c1f5ca1: 8303623: Compiler should disallow non-standard UTF-8 string encodings
• 695683b: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC
• 83ce65e: 8305004: add @SPEC tags to langtools modules
• 32ef452: 8304884: Update Bytecodes data to be mostly compile time constants
• 927e674: 8300977: Retire java.io.ExpiringCache
• c90699e: 8304989: unnecessary dash in @param gives double-dash in docs
• ... and 29 more: https://git.openjdk.org/jdk/compare/38e17148faef7799515478bd834ed2fa1a5153de...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit 50a995f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.