Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253060: remove test/hotspot/jtreg/test_env.sh #132

Closed
wants to merge 1 commit into from

Conversation

@iignatev
Copy link
Member

@iignatev iignatev commented Sep 11, 2020

JDK-8252402 removed the last shell test from test/hotspot/jtreg, and now test_env.sh can be removed so it won't trick anyone into believing that shell tests are acceptable/desirable/supported in hotspot testbase.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/132/head:pull/132
$ git checkout pull/132

@iignatev iignatev marked this pull request as ready for review Sep 11, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 11, 2020

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2020

@iignatev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d awt beans build compiler core-libs hotspot hotspot-compiler hotspot-gc hotspot-jfr hotspot-runtime i18n javadoc jdk jmx kulla net nio security serviceability shenandoah sound swing.

Loading

@iignatev
Copy link
Member Author

@iignatev iignatev commented Sep 11, 2020

/label add hotspot

Loading

@openjdk openjdk bot added the hotspot label Sep 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2020

@iignatev
The hotspot label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 11, 2020

Webrevs

Loading

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Simple file removal so this is a trivial change.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2020

@iignatev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253060: remove test/hotspot/jtreg/test_env.sh

Reviewed-by: dcubed
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 952518640a50ce86ca6f295867cfde93f6ac8b26.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 11, 2020
@iignatev
Copy link
Member Author

@iignatev iignatev commented Sep 11, 2020

Thanks, Dan!

Loading

@iignatev
Copy link
Member Author

@iignatev iignatev commented Sep 11, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2020

@iignatev Pushed as commit 5c0d985.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@iignatev iignatev deleted the 8253060 branch Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants