-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8304840: Dangling CharacterCodingException
in a few javadoc descriptions
#13214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8304840: Dangling CharacterCodingException
in a few javadoc descriptions
#13214
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
/label add core-libs |
@naotoj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means the descriptions are duplicate but I think better than making reader be concerned about other conditions that aren't specified. So I think this is okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Associated CSR also Reviewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit e3855d0. |
Fixing a documentation bug for
CharacterCodingException
without any description to it as attached. A corresponding CSR is also drafted.Progress
Issues
CharacterCodingException
in a few javadoc descriptionsCharacterCodingException
in a few javadoc descriptions (CSR)Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13214/head:pull/13214
$ git checkout pull/13214
Update a local copy of the PR:
$ git checkout pull/13214
$ git pull https://git.openjdk.org/jdk.git pull/13214/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13214
View PR using the GUI difftool:
$ git pr show -t 13214
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13214.diff