Skip to content

8304840: Dangling CharacterCodingException in a few javadoc descriptions #13214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Mar 28, 2023

Fixing a documentation bug for CharacterCodingException without any description to it as attached. A corresponding CSR is also drafted.

Screenshot 2023-03-28 at 11 19 00 AM


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8305099 to be approved

Issues

  • JDK-8304840: Dangling CharacterCodingException in a few javadoc descriptions
  • JDK-8305099: Dangling CharacterCodingException in a few javadoc descriptions (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13214/head:pull/13214
$ git checkout pull/13214

Update a local copy of the PR:
$ git checkout pull/13214
$ git pull https://git.openjdk.org/jdk.git pull/13214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13214

View PR using the GUI difftool:
$ git pr show -t 13214

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13214.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Mar 28, 2023
@openjdk
Copy link

openjdk bot commented Mar 28, 2023

@naotoj The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Mar 28, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2023

Webrevs

@naotoj
Copy link
Member Author

naotoj commented Mar 28, 2023

/label add core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 28, 2023
@openjdk
Copy link

openjdk bot commented Mar 28, 2023

@naotoj
The core-libs label was successfully added.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means the descriptions are duplicate but I think better than making reader be concerned about other conditions that aren't specified. So I think this is okay.

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Associated CSR also Reviewed.

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Mar 29, 2023
@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304840: Dangling `CharacterCodingException` in a few javadoc descriptions

Reviewed-by: alanb, iris, rriggs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 29, 2023
@naotoj
Copy link
Member Author

naotoj commented Mar 29, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 29, 2023

Going to push as commit e3855d0.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2023
@openjdk openjdk bot closed this Mar 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2023
@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@naotoj Pushed as commit e3855d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

5 participants