Skip to content

8304990: unnecessary dash in @param gives double-dash in docs #13217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented Mar 28, 2023

Please review this trivial change which removes a redundant - from an @param and cleans up the formatting for the isValid method.

It looks like there is some additional formatting clean up that can be done but I will handle that under a separate PR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13217/head:pull/13217
$ git checkout pull/13217

Update a local copy of the PR:
$ git checkout pull/13217
$ git pull https://git.openjdk.org/jdk.git pull/13217/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13217

View PR using the GUI difftool:
$ git pr show -t 13217

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13217.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2023

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2023
@openjdk
Copy link

openjdk bot commented Mar 28, 2023

@LanceAndersen The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 28, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 28, 2023

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304990: unnecessary dash in @param gives double-dash in docs

Reviewed-by: bpb, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2023
@LanceAndersen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 29, 2023

Going to push as commit 2fa0933.
Since your change was applied there have been 4 commits pushed to the master branch:

  • e56bcb0: 8305095: Update java/net/httpclient/CustomRequestPublisher.java to use new HttpTestServer factory methods
  • 0985288: 8304681: compiler/sharedstubs/SharedStubToInterpTest.java fails after JDK-8304387
  • ff368d5: 8304867: Explicitly disable dtrace for ppc builds
  • 96fa275: 8305112: RISC-V: Typo fix for RVC description

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2023
@openjdk openjdk bot closed this Mar 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2023
@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@LanceAndersen Pushed as commit 2fa0933.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants