-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8304990: unnecessary dash in @param gives double-dash in docs #13217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back lancea! A progress list of the required criteria for merging this PR into |
@LanceAndersen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@LanceAndersen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 2fa0933.
Your commit was automatically rebased without conflicts. |
@LanceAndersen Pushed as commit 2fa0933. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this trivial change which removes a redundant
-
from an@param
and cleans up the formatting for theisValid
method.It looks like there is some additional formatting clean up that can be done but I will handle that under a separate PR.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13217/head:pull/13217
$ git checkout pull/13217
Update a local copy of the PR:
$ git checkout pull/13217
$ git pull https://git.openjdk.org/jdk.git pull/13217/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13217
View PR using the GUI difftool:
$ git pr show -t 13217
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13217.diff