8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()

[reinrich]

This PR replaces a sequence of assembler instructions in the interpreter with an equivalent call of InterpreterMacroAssembler::load_resolved_indy_entry().

Tested hotspot tier1.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13226/head:pull/13226
$ git checkout pull/13226

Update a local copy of the PR:
$ git checkout pull/13226
$ git pull https://git.openjdk.org/jdk.git pull/13226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13226

View PR using the GUI difftool:
$ git pr show -t 13226

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13226.diff

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@reinrich The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (93ea5549)

[TheRealMDoerr]

LGTM. Thanks for cleaning this up!

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 9df2060: 8305157: The java.util.Arrays class should be declared final
• b261e6c: 8304445: Remaining uses of NULL in ciInstanceKlass.cpp
• 2c38e67: 8302644: IGV: Apply filters per graph tab and not globally
• f0dba21: 8304871: Use default visibility for static library builds
• 77811fa: 8305222: Change unique_ctrl_out_or_null to unique_ctrl_out in PhaseCFG::convert_NeverBranch_to_Goto
• 2d607c9: 8262294: java/net/httpclient/ProxyAuthDisabledSchemes.java fails with HTTP/1.1 parser received no bytes
• b3ff8d1: 8303805: [REDO] JDK-8302189 and JDK-8302799
• b524a74: 8301106: Allow archived Java strings to be moved by GC
• 9643f65: 8304436: com/sun/jdi/ThreadMemoryLeakTest.java fails with "OutOfMemoryError: Java heap space" with ZGC
• 69152c3: 8305202: Fix Copyright Header in ZonedDateTimeFormatterBenchmark
• ... and 12 more: https://git.openjdk.org/jdk/compare/ff368d504e9101e11c7182185f56255f429d31e3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[reinrich]

Thanks Martin!

[reinrich]

/integrate

[openjdk]

Going to push as commit c8f3a97.
Since your change was applied there have been 31 commits pushed to the master branch:

• 7fe5bd2: 8305174: disable dtrace for s390x builds
• 787832a: 8304988: unnecessary dash in @param gives double-dash in docs
• a144c71: 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp
• d815889: 8304993: bad sentence break in DateFormat
• 5f7b4b8: 8305111: Locale.lookupTag has typo in parameter
• 83cf28f: 8305142: Can't bootstrap ctw.jar
• 05cc02b: 8202110: (fs) Remove FileSystem support for resolving against a default directory (chdir configuration)
• d2df36b: 8299333: Unify exceptions used by all variants of ICC_Profile.getInstance(null)
• 1d7bb1f: 8304585: Method::invoke rewraps InvocationTargetException if a caller-sensitive method throws IAE
• 9df2060: 8305157: The java.util.Arrays class should be declared final
• ... and 21 more: https://git.openjdk.org/jdk/compare/ff368d504e9101e11c7182185f56255f429d31e3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit c8f3a97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.