8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized

[dougxc]

Class initialization can fail for the boxing caches such as Long$LongCache due to things such as a StackOverflowError.
When rematerializing boxed values during deoptimization, a failed cache initialization must be handled. This PR handles it by throwing an OOME which is always semantically correct.

Note that a VM with a broken boxing cache is going to be in a fairly miserable state (i.e. throwing NoClassDefFoundError on every call to Long.valueOf) so the OOME shouldn't cause any noticeable problem.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)
• Igor Veresov (@veresov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13229/head:pull/13229
$ git checkout pull/13229

Update a local copy of the PR:
$ git checkout pull/13229
$ git pull https://git.openjdk.org/jdk.git pull/13229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13229

View PR using the GUI difftool:
$ git pr show -t 13229

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13229.diff

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[dougxc]

This code has not been necessary ever since

jdk/src/hotspot/share/jvmci/jvmciCodeInstaller.cpp

Line 985 in e56bcb0

JVMCI::ensure_box_caches_initialized(CHECK_(JVMCI::ok));

was added.

[tkrodriguez]

How are the caches uninitialized if we have forced their initialization?

[dougxc]

A box cache initialization can fail due to StackOverflowError. In this case, we must not rematerialize a virtual object corresponding to a value that would be read from a box cache.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (51ebbc5f)

[tkrodriguez]

This looks good to me. There's really no other way to handle it.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized

Reviewed-by: never, iveresov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

• fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
• 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
• 049b953: 8305223: IGV: mark osr compiled graphs with [OSR] in the name
• 345669c: 8302738: IGV: refine 'Simplify graph' filter
• dea9db2: 8305055: IR check fails on some aarch64 platforms
• c8f3a97: 8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()
• 7fe5bd2: 8305174: disable dtrace for s390x builds
• 787832a: 8304988: unnecessary dash in @param gives double-dash in docs
• a144c71: 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp
• d815889: 8304993: bad sentence break in DateFormat
• ... and 42 more: https://git.openjdk.org/jdk/compare/395a4ce0dd4181bbb4bc0888038309901ebf8fea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[veresov]

Looks ok

[dougxc]

Thanks @veresov and @tkrodriguez for reviewing.

/integrate

[openjdk]

Going to push as commit e012685.
Since your change was applied there have been 52 commits pushed to the master branch:

• fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
• 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
• 049b953: 8305223: IGV: mark osr compiled graphs with [OSR] in the name
• 345669c: 8302738: IGV: refine 'Simplify graph' filter
• dea9db2: 8305055: IR check fails on some aarch64 platforms
• c8f3a97: 8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()
• 7fe5bd2: 8305174: disable dtrace for s390x builds
• 787832a: 8304988: unnecessary dash in @param gives double-dash in docs
• a144c71: 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp
• d815889: 8304993: bad sentence break in DateFormat
• ... and 42 more: https://git.openjdk.org/jdk/compare/395a4ce0dd4181bbb4bc0888038309901ebf8fea...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit e012685.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.