Skip to content

8305202: Fix Copyright Header in ZonedDateTimeFormatterBenchmark#13232

Closed
dfuch wants to merge 1 commit intoopenjdk:masterfrom
dfuch:8305202
Closed

8305202: Fix Copyright Header in ZonedDateTimeFormatterBenchmark#13232
dfuch wants to merge 1 commit intoopenjdk:masterfrom
dfuch:8305202

Conversation

@dfuch
Copy link
Member

@dfuch dfuch commented Mar 29, 2023

There is a space missing in the ZonedDateTimeFormatterBenchmark copyright header


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305202: Fix Copyright Header in ZonedDateTimeFormatterBenchmark

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13232/head:pull/13232
$ git checkout pull/13232

Update a local copy of the PR:
$ git checkout pull/13232
$ git pull https://git.openjdk.org/jdk.git pull/13232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13232

View PR using the GUI difftool:
$ git pr show -t 13232

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13232.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2023

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305202: Fix Copyright Header in ZonedDateTimeFormatterBenchmark

Reviewed-by: rriggs, naoto, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2023
@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@dfuch To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dfuch
Copy link
Member Author

dfuch commented Mar 29, 2023

/integrate

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented Mar 29, 2023

Going to push as commit 69152c3.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2023
@openjdk openjdk bot closed this Mar 29, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Mar 29, 2023
@dfuch
Copy link
Member Author

dfuch commented Mar 29, 2023

/integrate

@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 29, 2023
@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@dfuch Pushed as commit 69152c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@dfuch The command integrate can only be used in open pull requests.

@dfuch dfuch deleted the 8305202 branch March 29, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants