8305055: IR check fails on some aarch64 platforms

[fg1417]

As @eme64 said in [1], JDK-8298935 introduced some "collateral damage", disabling the vectorization of some conversions when +AlignVector. That affects IR checks of TestVectorizeTypeConversion.java and ArrayTypeConvertTest.java on some aarch64 platforms like ThunderX and ThunderX2 [2].

This trivial patch is to allow IR check only when we have -AlignVector.

[1] #12350 (comment)
[2]

jdk/src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

Line 154 in 7239150

// ThunderX

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305055: IR check fails on some aarch64 platforms

Reviewers

• Emanuel Peter (@eme64 - Committer) ⚠️ Review applies to 78fcd6e5
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13236/head:pull/13236
$ git checkout pull/13236

Update a local copy of the PR:
$ git checkout pull/13236
$ git pull https://git.openjdk.org/jdk.git pull/13236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13236

View PR using the GUI difftool:
$ git pr show -t 13236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13236.diff

[bridgekeeper]

👋 Welcome back fgao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fg1417 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (04f8b116)
• 00: Full (78fcd6e5)

[eme64]

@fg1417 Thanks for doing this.
I guess this is only a temporary solution?
We should revert this change when we fix JDK-8303827. I added a comment to that RFE.

[eme64]

@fg1417 Maybe rather than mentioning JDK-8298935 in the test, you could mention that we can remove it after JDK-8303827.

[eme64]

Otherwise looks good.

[TobiHartmann]

+1 to Emanuel's suggestion. Looks good to me otherwise.

[openjdk]

@fg1417 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305055: IR check fails on some aarch64 platforms

Reviewed-by: epeter, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 2c38e67: 8302644: IGV: Apply filters per graph tab and not globally
• f0dba21: 8304871: Use default visibility for static library builds
• 77811fa: 8305222: Change unique_ctrl_out_or_null to unique_ctrl_out in PhaseCFG::convert_NeverBranch_to_Goto
• 2d607c9: 8262294: java/net/httpclient/ProxyAuthDisabledSchemes.java fails with HTTP/1.1 parser received no bytes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[fg1417]

Thanks for your kind review and suggestion, @eme64 @TobiHartmann . Updated the comments in the new commit.

[fg1417]

The GHA failure of runtime/ErrorHandling/TestDwarf is not related to this PR. I'll integrate it.

[fg1417]

/integrate

[openjdk]

Going to push as commit dea9db2.
Since your change was applied there have been 16 commits pushed to the master branch:

• c8f3a97: 8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()
• 7fe5bd2: 8305174: disable dtrace for s390x builds
• 787832a: 8304988: unnecessary dash in @param gives double-dash in docs
• a144c71: 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp
• d815889: 8304993: bad sentence break in DateFormat
• 5f7b4b8: 8305111: Locale.lookupTag has typo in parameter
• 83cf28f: 8305142: Can't bootstrap ctw.jar
• 05cc02b: 8202110: (fs) Remove FileSystem support for resolving against a default directory (chdir configuration)
• d2df36b: 8299333: Unify exceptions used by all variants of ICC_Profile.getInstance(null)
• 1d7bb1f: 8304585: Method::invoke rewraps InvocationTargetException if a caller-sensitive method throws IAE
• ... and 6 more: https://git.openjdk.org/jdk/compare/b3ff8d1c89b0f968b7b5ec2105502778524e4e4a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fg1417 Pushed as commit dea9db2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.