8305227: [s390x] build broken after JDK-8231349

[offamitkumar]

This PR moves nmethod entry barrier from generate_compiler_stubs() to generate_final_stubs(). Test build for fastdebug, slow debug, release and optimised. Tier1 test in fastdebug seems clean as well.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305227: [s390x] build broken after JDK-8231349

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Lutz Schmidt (@RealLucy - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13259/head:pull/13259
$ git checkout pull/13259

Update a local copy of the PR:
$ git checkout pull/13259
$ git pull https://git.openjdk.org/jdk.git pull/13259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13259

View PR using the GUI difftool:
$ git pr show -t 13259

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13259.diff

[bridgekeeper]

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@offamitkumar The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[offamitkumar]

Hi @vnkozlov , @RealLucy

Please do review this PR.

Thanks.

[mlbridge]

Webrevs

• 00: Full (28219ca0)

[shipilev]

Looks fine to me.

[openjdk]

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305227: [s390x] build broken after JDK-8231349

Reviewed-by: shade, lucy, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• dae1ab3: 8304844: JFR: Missing disk parameter in ActiveRecording event
• e012685: 8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized
• fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
• 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
• 049b953: 8305223: IGV: mark osr compiled graphs with [OSR] in the name
• 345669c: 8302738: IGV: refine 'Simplify graph' filter
• dea9db2: 8305055: IR check fails on some aarch64 platforms
• c8f3a97: 8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()
• 7fe5bd2: 8305174: disable dtrace for s390x builds
• 787832a: 8304988: unnecessary dash in @param gives double-dash in docs
• ... and 27 more: https://git.openjdk.org/jdk/compare/e56bcb04b11c6494e6afdf0bd9b9bc65a4769347...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @RealLucy, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[RealLucy]

LGTM and resolves the crash observed.
@offamitkumar Thanks for fixing!
@vnkozlov Thanks for helping out!

[vnkozlov]

Good.

[offamitkumar]

Thanks @vnkozlov
/integrate

Hi Reviewers,
Please sponsor as well :-)

[openjdk]

@offamitkumar
Your change (at version 28219ca) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 4a5d7ca.
Since your change was applied there have been 37 commits pushed to the master branch:

• dae1ab3: 8304844: JFR: Missing disk parameter in ActiveRecording event
• e012685: 8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized
• fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
• 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
• 049b953: 8305223: IGV: mark osr compiled graphs with [OSR] in the name
• 345669c: 8302738: IGV: refine 'Simplify graph' filter
• dea9db2: 8305055: IR check fails on some aarch64 platforms
• c8f3a97: 8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()
• 7fe5bd2: 8305174: disable dtrace for s390x builds
• 787832a: 8304988: unnecessary dash in @param gives double-dash in docs
• ... and 27 more: https://git.openjdk.org/jdk/compare/e56bcb04b11c6494e6afdf0bd9b9bc65a4769347...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @offamitkumar Pushed as commit 4a5d7ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.