Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7124527: [macosx] SwingSet2, label is not read by VoiceOver when focus is on textfield for Internalframe and Table demo. #13268

Closed
wants to merge 2 commits into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Mar 31, 2023

In SwingSet2, few label components are not set for textfield component in InternalFrame and Table demo and due to this VoiceOver doesn't announce the label along with the textfield value. Added a fix for that and verified in SwingSet2.

Apart from that for Selection mode combobox and Autoresize combobox, VoiceOver doesn't announce the combobox panel details along with combobox current item.

Although the bug doesn't report this but in Slider demo it is observed that VoiceOver announces the slider value and panel details together.

So, added a fix similar to slider demo for combobox in tabledemo.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7124527: [macosx] SwingSet2, label is not read by VoiceOver when focus is on textfield for Internalframe and Table demo.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13268/head:pull/13268
$ git checkout pull/13268

Update a local copy of the PR:
$ git checkout pull/13268
$ git pull https://git.openjdk.org/jdk.git pull/13268/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13268

View PR using the GUI difftool:
$ git pr show -t 13268

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13268.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2023

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2023
@openjdk
Copy link

openjdk bot commented Mar 31, 2023

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 31, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2023

Webrevs

@kumarabhi006
Copy link
Contributor Author

@azuev-java Please review the changes.

@mrserb
Copy link
Member

mrserb commented Mar 31, 2023

Looks fine, please update the dates in the copyright block.

Copy link
Contributor

@savoptik savoptik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kumarabhi006
Copy link
Contributor Author

Looks fine, please update the dates in the copyright block.

Copyright year updated.

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7124527: [macosx] SwingSet2, label is not read by VoiceOver when focus is on textfield for Internalframe and Table demo.

Reviewed-by: asemenov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

  • 15fa78e: 8305237: CompilerDirectives DCmds permissions correction
  • 7cf24d1: 8305400: ISO 4217 Amendment 175 Update
  • a324fa2: 8225641: Calendar.roll(int field) does not work correctly for WEEK_OF_YEAR
  • 3399fbf: 8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java
  • 94a05e0: 8305599: (fc) Temporarily problem-list java/nio/channels/{AsyncCloseAndInterrupt.java, FileChannel/Transfer.java}
  • 7c65048: 8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value
  • dd59471: 8304846: Provide a shared utility to dump generated classes defined via Lookup API
  • 2ee4245: 8305509: C1 fails "assert(k != nullptr) failed: illegal use of unloaded klass"
  • 7baccd9: 8303260: (fc) FileChannel::transferFrom should support position > size()
  • 3ef834f: 8298619: java/io/File/GetXSpace.java is failing
  • ... and 64 more: https://git.openjdk.org/jdk/compare/2c38e67b296c7133dae36d5dbd0064c602b85d4f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2023
@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2023

Going to push as commit 0ec3d2e.
Since your change was applied there have been 75 commits pushed to the master branch:

  • ed9592c: 8305113: (tz) Update Timezone Data to 2023c
  • 15fa78e: 8305237: CompilerDirectives DCmds permissions correction
  • 7cf24d1: 8305400: ISO 4217 Amendment 175 Update
  • a324fa2: 8225641: Calendar.roll(int field) does not work correctly for WEEK_OF_YEAR
  • 3399fbf: 8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java
  • 94a05e0: 8305599: (fc) Temporarily problem-list java/nio/channels/{AsyncCloseAndInterrupt.java, FileChannel/Transfer.java}
  • 7c65048: 8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value
  • dd59471: 8304846: Provide a shared utility to dump generated classes defined via Lookup API
  • 2ee4245: 8305509: C1 fails "assert(k != nullptr) failed: illegal use of unloaded klass"
  • 7baccd9: 8303260: (fc) FileChannel::transferFrom should support position > size()
  • ... and 65 more: https://git.openjdk.org/jdk/compare/2c38e67b296c7133dae36d5dbd0064c602b85d4f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2023
@openjdk openjdk bot closed this Apr 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2023
@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@kumarabhi006 Pushed as commit 0ec3d2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants