8283404: [macos] a11y : Screen magnifier does not show JMenu name

[kumarabhi006]

It seems that the accessibility role returned by the MenuAccessibility class is not correct for top level menu.

Added a condition check to return the accessibility role as NSAccessibilityMenuBarItemRole in stead of NSAccessibilityMenuRole for top level menu whose parent is menubar.

The solution works correctly for screen magnifier as well as voice over.

A manual test case is added to verify the fix.

Note: Tried implementing few a11y methods to fix but for top level menu with NSAccessibilityMenuRole doesn't return the a11y label.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8283404: [macos] a11y : Screen magnifier does not show JMenu name

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• @M4ximumPizza (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13271/head:pull/13271
$ git checkout pull/13271

Update a local copy of the PR:
$ git checkout pull/13271
$ git pull https://git.openjdk.org/jdk.git pull/13271/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13271

View PR using the GUI difftool:
$ git pr show -t 13271

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13271.diff

[bridgekeeper]

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kumarabhi006 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (5a4972aa)
• 00: Full (3c668b46)

[mrserb]

What the user should "Run" at this step?

[kumarabhi006]

This step is not required. Copy+paste mistake from JBS description.
I will update the test instruction.

[kumarabhi006]

What the user should "Run" at this step?

Updated the test instruction.

[openjdk]

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283404: [macos] a11y : Screen magnifier does not show JMenu name

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• aa76210: 8304893: Link Time Optimization with gcc can be faster
• b8c748d: 8294266: Add a way to pre-touch java thread stacks
• 41a3db2: 8304815: Use NMT for more precise hs_err location printing
• 34e66ce: 8304295: harfbuzz build fails with GCC 7 after JDK-8301998
• a19b28a: 8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick
• 8eb4e7e: 8277501: Revisit PathFileObject.getCharContent and friends
• abfb900: 8304028: Port fdlibm IEEEremainder to Java
• a565be4: 8297605: improve DelayQueue removal method javadoc
• cccb019: 8304928: Optimize ClassDesc.resolveConstantDesc
• bdbf8fc: 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value
• ... and 20 more: https://git.openjdk.org/jdk/compare/2c38e67b296c7133dae36d5dbd0064c602b85d4f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kumarabhi006]

/integrate

[openjdk]

Going to push as commit ecec611.
Since your change was applied there have been 30 commits pushed to the master branch:

• aa76210: 8304893: Link Time Optimization with gcc can be faster
• b8c748d: 8294266: Add a way to pre-touch java thread stacks
• 41a3db2: 8304815: Use NMT for more precise hs_err location printing
• 34e66ce: 8304295: harfbuzz build fails with GCC 7 after JDK-8301998
• a19b28a: 8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick
• 8eb4e7e: 8277501: Revisit PathFileObject.getCharContent and friends
• abfb900: 8304028: Port fdlibm IEEEremainder to Java
• a565be4: 8297605: improve DelayQueue removal method javadoc
• cccb019: 8304928: Optimize ClassDesc.resolveConstantDesc
• bdbf8fc: 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value
• ... and 20 more: https://git.openjdk.org/jdk/compare/2c38e67b296c7133dae36d5dbd0064c602b85d4f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kumarabhi006 Pushed as commit ecec611.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.