Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305400: ISO 4217 Amendment 175 Update #13275

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Mar 31, 2023

Please review the ISO 4217 amendment 175 update.

There are no meaningful code changes, but the version number should be updated accordingly to be in sync.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13275/head:pull/13275
$ git checkout pull/13275

Update a local copy of the PR:
$ git checkout pull/13275
$ git pull https://git.openjdk.org/jdk.git pull/13275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13275

View PR using the GUI difftool:
$ git pr show -t 13275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13275.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2023
@openjdk
Copy link

openjdk bot commented Mar 31, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 31, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2023

Webrevs

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you track the legal tender date? Because that did change, for CLDR unicode-org/cldr#2825

@naotoj
Copy link
Member

naotoj commented Mar 31, 2023

Do you track the legal tender date? Because that did change, for CLDR unicode-org/cldr#2825

Hi Steven,
No, JDK does not provide either historical currency information or dates. Currency.getInstance(Locale) always returns the new currency during the transition period by default. (Can be manipulated by modifying the currency.properties file)

@openjdk
Copy link

openjdk bot commented Mar 31, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305400: ISO 4217 Amendment 175 Update

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 31, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@justin-curtis-lu
Your change (at version 81e6e89) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Apr 4, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

Going to push as commit 7cf24d1.
Since your change was applied there have been 81 commits pushed to the master branch:

  • a324fa2: 8225641: Calendar.roll(int field) does not work correctly for WEEK_OF_YEAR
  • 3399fbf: 8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java
  • 94a05e0: 8305599: (fc) Temporarily problem-list java/nio/channels/{AsyncCloseAndInterrupt.java, FileChannel/Transfer.java}
  • 7c65048: 8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value
  • dd59471: 8304846: Provide a shared utility to dump generated classes defined via Lookup API
  • 2ee4245: 8305509: C1 fails "assert(k != nullptr) failed: illegal use of unloaded klass"
  • 7baccd9: 8303260: (fc) FileChannel::transferFrom should support position > size()
  • 3ef834f: 8298619: java/io/File/GetXSpace.java is failing
  • c594119: 8305511: Remove ignore from com/sun/jdi/PopAndInvokeTest.java
  • 62bd2eb: 8303147: [s390x] fast & slow debug builds are broken
  • ... and 71 more: https://git.openjdk.org/jdk/compare/d063b8964fbdd6ca1d9527dabb40fed59bbc8ad7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2023
@openjdk openjdk bot closed this Apr 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@naotoj @justin-curtis-lu Pushed as commit 7cf24d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
4 participants