8305421: Work around JDK-8305420 in CDSJDITest.java

[iklam]

Please review this trivial work-around that removes logging that would trigger JDK-8305420.

I also fixed an incorrect parameter in the executeAndLog() call, which caused the dumping process's stdout/stderr to be logged in the wrong file.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305421: Work around JDK-8305420 in CDSJDITest.java

Reviewers

• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13283/head:pull/13283
$ git checkout pull/13283

Update a local copy of the PR:
$ git checkout pull/13283
$ git pull https://git.openjdk.org/jdk.git pull/13283/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13283

View PR using the GUI difftool:
$ git pr show -t 13283

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13283.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (81b8b8e8)

[plummercj]

Change looks good. Per https://bugs.openjdk.org/browse/JDK-8173304, this is a known issue and tests need to avoid having the JVM produce too much output before the debugger connection is setup.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305421: Work around JDK-8305420 in CDSJDITest.java

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• b062b1b: 8304743: Compile_lock and SystemDictionary updates
• df819cf: 8304945: StringBuilder and StringBuffer should implement Appendable explicitly
• 312bbe7: 8305485: Problemlist runtime/Thread/TestAlwaysPreTouchStacks.java
• 50e31e0: 8305442: (bf) Direct and view implementations of CharBuffer.toString(int, int) do not need to catch SIOBE
• 85e3974: 8304014: Convert test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java to junit
• 40aea04: 8278268: (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets
• 9b9b5a7: 8302323: Add repeat methods to StringBuilder/StringBuffer
• dd7ca75: 8305478: [REDO] disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
• f9827ad: 8288109: HttpExchangeImpl.setAttribute does not allow null value after JDK-8266897
• 6010de0: 8305417: disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
• ... and 8 more: https://git.openjdk.org/jdk/compare/aa762102e9328ca76663b56b3be6f6141b044744...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

Thanks @plummercj for the review.
/integrate

[openjdk]

Going to push as commit 9ce5fdc.
Since your change was applied there have been 18 commits pushed to the master branch:

• b062b1b: 8304743: Compile_lock and SystemDictionary updates
• df819cf: 8304945: StringBuilder and StringBuffer should implement Appendable explicitly
• 312bbe7: 8305485: Problemlist runtime/Thread/TestAlwaysPreTouchStacks.java
• 50e31e0: 8305442: (bf) Direct and view implementations of CharBuffer.toString(int, int) do not need to catch SIOBE
• 85e3974: 8304014: Convert test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java to junit
• 40aea04: 8278268: (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets
• 9b9b5a7: 8302323: Add repeat methods to StringBuilder/StringBuffer
• dd7ca75: 8305478: [REDO] disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
• f9827ad: 8288109: HttpExchangeImpl.setAttribute does not allow null value after JDK-8266897
• 6010de0: 8305417: disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
• ... and 8 more: https://git.openjdk.org/jdk/compare/aa762102e9328ca76663b56b3be6f6141b044744...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 9ce5fdc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.