8305442: (bf) Direct and view implementations of CharBuffer.toString(int, int) do not need to catch SIOBE

[stsypanov]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305442: (bf) Direct and view implementations of CharBuffer.toString(int, int) do not need to catch SIOBE

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13286/head:pull/13286
$ git checkout pull/13286

Update a local copy of the PR:
$ git checkout pull/13286
$ git pull https://git.openjdk.org/jdk.git pull/13286/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13286

View PR using the GUI difftool:
$ git pr show -t 13286

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13286.diff

[bridgekeeper]

👋 Welcome back stsypanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stsypanov The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4379cac1)

[AlanBateman]

I suspect this goes back to the original implementation. I assume you'll run the jdk_nio tests.

[openjdk]

@stsypanov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305442: (bf) Direct and view implementations of CharBuffer.toString(int, int) do not need to catch SIOBE

Reviewed-by: alanb, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 175 new commits pushed to the master branch:

• 40aea04: 8278268: (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets
• 9b9b5a7: 8302323: Add repeat methods to StringBuilder/StringBuffer
• dd7ca75: 8305478: [REDO] disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
• f9827ad: 8288109: HttpExchangeImpl.setAttribute does not allow null value after JDK-8266897
• 6010de0: 8305417: disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
• 127afd3: 8241613: Suspicious calls to MacroAssembler::null_check(Register, offset)
• 33d09e5: 8305247: On RISC-V generate_fixed_frame() sometimes generate a relativized locals value which is way too large
• 790aced: 8305100: [REDO] Clean up JavadocTokenizer
• 2e91585: 8303123: Add line break opportunity to single type parameters
• 094e03d: 8299718: JavaDoc: Buttons to copy specific documentation URL are not accessible
• ... and 165 more: https://git.openjdk.org/jdk/compare/c396f1ed8b91b799fdd6a9a849d7407e606227d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[stsypanov]

@AlanBateman FYI

make test TEST=jdk_nio
==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk:jdk_nio                              471   471     0     0   
==============================
TEST SUCCESS

[stsypanov]

/integrate

[openjdk]

@stsypanov
Your change (at version 4379cac) is now ready to be sponsored by a Committer.

[bplb]

Looks fine and builds.

[bplb]

/sponsor

[openjdk]

Going to push as commit 50e31e0.
Since your change was applied there have been 176 commits pushed to the master branch:

• 85e3974: 8304014: Convert test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java to junit
• 40aea04: 8278268: (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets
• 9b9b5a7: 8302323: Add repeat methods to StringBuilder/StringBuffer
• dd7ca75: 8305478: [REDO] disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
• f9827ad: 8288109: HttpExchangeImpl.setAttribute does not allow null value after JDK-8266897
• 6010de0: 8305417: disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
• 127afd3: 8241613: Suspicious calls to MacroAssembler::null_check(Register, offset)
• 33d09e5: 8305247: On RISC-V generate_fixed_frame() sometimes generate a relativized locals value which is way too large
• 790aced: 8305100: [REDO] Clean up JavadocTokenizer
• 2e91585: 8303123: Add line break opportunity to single type parameters
• ... and 166 more: https://git.openjdk.org/jdk/compare/c396f1ed8b91b799fdd6a9a849d7407e606227d5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb @stsypanov Pushed as commit 50e31e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.