Skip to content

8305520: ToggleNotifyJvmtiTest.java fails with release VMs #13318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Apr 4, 2023

Add -XX:+UnlockDiagnosticVMOptions to fix the failure with release VMs.
Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305520: ToggleNotifyJvmtiTest.java fails with release VMs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13318/head:pull/13318
$ git checkout pull/13318

Update a local copy of the PR:
$ git checkout pull/13318
$ git pull https://git.openjdk.org/jdk.git pull/13318/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13318

View PR using the GUI difftool:
$ git pr show -t 13318

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13318.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2023

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@DamonFool The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 4, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2023

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.
Thank you for taking care about it.
-Serguei

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305520: ToggleNotifyJvmtiTest.java fails with release VMs

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 24c6af0: 8173709: Fix VerifyLoopOptimizations - step 1 - minimal infrastructure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2023
@DamonFool
Copy link
Member Author

Looks good and trivial. Thank you for taking care about it. -Serguei

Thanks @sspitsyn for your review.
/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

Going to push as commit a663d5d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 24c6af0: 8173709: Fix VerifyLoopOptimizations - step 1 - minimal infrastructure

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2023
@openjdk openjdk bot closed this Apr 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@DamonFool Pushed as commit a663d5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8305520 branch April 4, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants