8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value

[rgiulietti]

A fix for the issue and additional specific tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13326/head:pull/13326
$ git checkout pull/13326

Update a local copy of the PR:
$ git checkout pull/13326
$ git pull https://git.openjdk.org/jdk.git pull/13326/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13326

View PR using the GUI difftool:
$ git pr show -t 13326

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13326.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b5cc4689)

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 2ee4245: 8305509: C1 fails "assert(k != nullptr) failed: illegal use of unloaded klass"
• 7baccd9: 8303260: (fc) FileChannel::transferFrom should support position > size()
• 3ef834f: 8298619: java/io/File/GetXSpace.java is failing
• c594119: 8305511: Remove ignore from com/sun/jdi/PopAndInvokeTest.java
• 62bd2eb: 8303147: [s390x] fast & slow debug builds are broken
• f9ed825: 8303082: [AIX] Missing C++ name demangling with XLClang++
• 73a084c: 8305504: stutter typo in java.compiler files
• 7b92210: 8305525: Problemlist runtime/ErrorHandling/TestDwarf on x86

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rgiulietti]

/integrate

[openjdk]

Going to push as commit 7c65048.
Since your change was applied there have been 9 commits pushed to the master branch:

• dd59471: 8304846: Provide a shared utility to dump generated classes defined via Lookup API
• 2ee4245: 8305509: C1 fails "assert(k != nullptr) failed: illegal use of unloaded klass"
• 7baccd9: 8303260: (fc) FileChannel::transferFrom should support position > size()
• 3ef834f: 8298619: java/io/File/GetXSpace.java is failing
• c594119: 8305511: Remove ignore from com/sun/jdi/PopAndInvokeTest.java
• 62bd2eb: 8303147: [s390x] fast & slow debug builds are broken
• f9ed825: 8303082: [AIX] Missing C++ name demangling with XLClang++
• 73a084c: 8305504: stutter typo in java.compiler files
• 7b92210: 8305525: Problemlist runtime/ErrorHandling/TestDwarf on x86

Your commit was automatically rebased without conflicts.

[openjdk]

@rgiulietti Pushed as commit 7c65048.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.