Skip to content

8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java #13334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Apr 4, 2023

This gives time to investigate JDK-8305600 and understand why the test didn't fail on my testing before the push.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13334/head:pull/13334
$ git checkout pull/13334

Update a local copy of the PR:
$ git checkout pull/13334
$ git pull https://git.openjdk.org/jdk.git pull/13334/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13334

View PR using the GUI difftool:
$ git pr show -t 13334

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13334.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2023

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@mlchung To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@mlchung mlchung changed the title ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java 8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java Apr 4, 2023
@mlchung
Copy link
Member Author

mlchung commented Apr 4, 2023

/label add core-libs

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 94a05e0: 8305599: (fc) Temporarily problem-list java/nio/channels/{AsyncCloseAndInterrupt.java, FileChannel/Transfer.java}

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review core-libs core-libs-dev@openjdk.org labels Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@mlchung
The core-libs label was successfully added.

@mlchung
Copy link
Member Author

mlchung commented Apr 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

Going to push as commit 3399fbf.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 94a05e0: 8305599: (fc) Temporarily problem-list java/nio/channels/{AsyncCloseAndInterrupt.java, FileChannel/Transfer.java}

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2023
@openjdk openjdk bot closed this Apr 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@mlchung Pushed as commit 3399fbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Apr 4, 2023

Webrevs

@mlchung mlchung deleted the JDK-8305602 branch August 2, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants