Skip to content

Conversation

@bplb
Copy link
Member

@bplb bplb commented Apr 5, 2023

Revert removal of FileSystem resolution against a default directory.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305664: [BACKOUT] (fs) Remove FileSystem support for resolving against a default directory (chdir configuration)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13355/head:pull/13355
$ git checkout pull/13355

Update a local copy of the PR:
$ git checkout pull/13355
$ git pull https://git.openjdk.org/jdk.git pull/13355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13355

View PR using the GUI difftool:
$ git pr show -t 13355

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13355.diff

Webrev

Link to Webrev Comment

…st a default directory (chdir configuration)
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 5, 2023
@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Apr 5, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305664: [BACKOUT] (fs) Remove FileSystem support for resolving against a default directory (chdir configuration)

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 44f33ad: 8304982: Emit warning for removal of COMPAT provider
  • ee30233: 8305107: Emoji related binary properties in RegEx
  • 5919fad: 8305591: Cleanup use of newline flag in DocCommentParser
  • 022290b: 8305620: Missing break in DocCommentParser inlineWord()
  • 2e59d21: 8305659: ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual threads
  • f69d88c: 8301616: Drag & maximize to another monitor places window incorrectly (Windows)
  • a3137c7: 8305646: compile error on Alpine with gcc12 after 8298619 in libGetXSpace.c
  • 78ff454: 8305490: CommandProcessor command "dumpclass" produces classes with invalid field descriptors
  • 9f587d2: 8305644: IGV: Node text not updated when switching from/to CFG view
  • 4bf1987: 8296454: System.console() shouldn't return null in jshell
  • ... and 10 more: https://git.openjdk.org/jdk/compare/94a05e0caa0d50df5cd569ce5a28d479363bb1fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 5, 2023
@bplb
Copy link
Member Author

bplb commented Apr 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2023

Going to push as commit 507c49a.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 39f12a8: 8305596: (fc) Two java/nio/channels tests fail after JDK-8303260
  • 44f33ad: 8304982: Emit warning for removal of COMPAT provider
  • ee30233: 8305107: Emoji related binary properties in RegEx
  • 5919fad: 8305591: Cleanup use of newline flag in DocCommentParser
  • 022290b: 8305620: Missing break in DocCommentParser inlineWord()
  • 2e59d21: 8305659: ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual threads
  • f69d88c: 8301616: Drag & maximize to another monitor places window incorrectly (Windows)
  • a3137c7: 8305646: compile error on Alpine with gcc12 after 8298619 in libGetXSpace.c
  • 78ff454: 8305490: CommandProcessor command "dumpclass" produces classes with invalid field descriptors
  • 9f587d2: 8305644: IGV: Node text not updated when switching from/to CFG view
  • ... and 11 more: https://git.openjdk.org/jdk/compare/94a05e0caa0d50df5cd569ce5a28d479363bb1fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2023
@openjdk openjdk bot closed this Apr 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2023
@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@bplb Pushed as commit 507c49a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the BACKOUT-lazy-UnixNativeDispatcher-8305664 branch April 5, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated nio nio-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants