Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256664: Shenandoah: Cleanup after JDK-8212879 #1336

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Nov 20, 2020

JDK-8212879 removed last serial weak roots, that means:

  1. Concurrent GC no longer needs to cleanup any weak roots at pause
  2. Root verifier no longer needs to distinguish concurrent/serial weak roots.

Test:

  • hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux aarch64 Linux arm Linux ppc64le Linux s390x Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (6/6 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) (1/9 failed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test task

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1336/head:pull/1336
$ git checkout pull/1336

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 20, 2020

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 20, 2020

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Nov 20, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 20, 2020

Webrevs

Copy link
Contributor

@rkennke rkennke left a comment

Looks good to me! Thank you!

@openjdk
Copy link

@openjdk openjdk bot commented Nov 20, 2020

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256664: Shenandoah: Cleanup after JDK-8212879

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • a25fb03: 8256406: G1 x86 C1/Interpreter post write barrier always uses 32 bit to access variable sized PtrQueue::_index
  • f576628: 8256633: Fix product build on Windows+Arm64
  • 8e7a855: 8255526: Enable jcheck whitespace checking of build system files
  • c45ab1a: 8256393: Github Actions build on Linux should define OS and GCC versions
  • 5fedb69: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
  • 02adaa5: 8255885: Metaspace: freelist commit counter is not updated when purging
  • fa240f2: 8256594: Unexpected warning: SIGSEGV handler flags expected:SA_RESTART|SA_SIGINFO found:SA_RESTART|SA_SIGINFO
  • 4c09525: 8256108: Create implementation for NSAccessibilityElement protocol peer
  • 6813889: 8251317: Support for CLDR version 38
  • c816464: 4916923: In MetalRootPaneUI, MetalRootLayout does not correctly calculate minimumsize
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/ba721f5f2fbbf08e22a9993dce0087f46b1f5552...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 20, 2020
@rkennke
Copy link
Contributor

@rkennke rkennke commented Nov 20, 2020

There is one failure in tier1/linux/x86_64, make sure this is not caused by this change!

@shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 20, 2020

There is one failure in tier1/linux/x86_64, make sure this is not caused by this change!

It seems to be https://bugs.openjdk.java.net/browse/JDK-8256641, and it manifests across many runs today.

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Nov 20, 2020

Looks good to me! Thank you!

Thanks.

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Nov 20, 2020

There is one failure in tier1/linux/x86_64, make sure this is not caused by this change!

It seems to be https://bugs.openjdk.java.net/browse/JDK-8256641, and it manifests across many runs today.

Yes, it is not related to this change.

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Nov 20, 2020

/integrate

@openjdk openjdk bot closed this Nov 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 20, 2020
@zhengyu123 zhengyu123 deleted the JDK-8256664-cleanup-jvmti branch Nov 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 20, 2020

@zhengyu123 Since your change was applied there have been 25 commits pushed to the master branch:

  • b99fd4c: 8033441: print line numbers with -XX:+PrintOptoAssembly
  • 266dea0: 8256688: Shenandoah: Lock rank inversion after JDK-8212879
  • aeba925: 8256416: ZGC: Lower ZMarkCompleteTimeout
  • 10ba541: 8256727: ZGC: Clean out dead code after JDK-8212879
  • eb35ade: 6232281: -XX:-UseLoopSafepoints causes assert(v_false,"Parse::remove_useless_nodes missed this node")
  • a25fb03: 8256406: G1 x86 C1/Interpreter post write barrier always uses 32 bit to access variable sized PtrQueue::_index
  • f576628: 8256633: Fix product build on Windows+Arm64
  • 8e7a855: 8255526: Enable jcheck whitespace checking of build system files
  • c45ab1a: 8256393: Github Actions build on Linux should define OS and GCC versions
  • 5fedb69: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/ba721f5f2fbbf08e22a9993dce0087f46b1f5552...master

Your commit was automatically rebased without conflicts.

Pushed as commit 98a5d5a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated shenandoah
3 participants