Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java #13394

Conversation

iklam
Copy link
Member

@iklam iklam commented Apr 7, 2023

This test has a high tendency of failing on hosts with strong ASLR settings. It should be problem listed to avoid noise in testing, until the test bug is properly fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13394/head:pull/13394
$ git checkout pull/13394

Update a local copy of the PR:
$ git checkout pull/13394
$ git pull https://git.openjdk.org/jdk.git pull/13394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13394

View PR using the GUI difftool:
$ git pr show -t 13394

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13394.diff

Webrev

Link to Webrev Comment

@iklam iklam marked this pull request as ready for review April 7, 2023 22:52
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2023

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 7, 2023
@openjdk
Copy link

openjdk bot commented Apr 7, 2023

@iklam To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@iklam
Copy link
Member Author

iklam commented Apr 7, 2023

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 7, 2023
@openjdk
Copy link

openjdk bot commented Apr 7, 2023

@iklam
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 7, 2023

Webrevs

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and trivial.

@openjdk
Copy link

openjdk bot commented Apr 8, 2023

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2023
@iklam
Copy link
Member Author

iklam commented Apr 8, 2023

Thanks @plummercj for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Apr 8, 2023

Going to push as commit f45b01f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2023
@openjdk openjdk bot closed this Apr 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 8, 2023
@openjdk
Copy link

openjdk bot commented Apr 8, 2023

@iklam Pushed as commit f45b01f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants