-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java #13394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java #13394
Conversation
|
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
|
@iklam To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/label add hotspot-runtime |
|
@iklam |
plummercj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and trivial.
|
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thanks @plummercj for the review. |
|
Going to push as commit f45b01f. |
This test has a high tendency of failing on hosts with strong ASLR settings. It should be problem listed to avoid noise in testing, until the test bug is properly fixed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13394/head:pull/13394$ git checkout pull/13394Update a local copy of the PR:
$ git checkout pull/13394$ git pull https://git.openjdk.org/jdk.git pull/13394/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13394View PR using the GUI difftool:
$ git pr show -t 13394Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13394.diff
Webrev
Link to Webrev Comment