Skip to content

Conversation

@liach
Copy link
Member

@liach liach commented Apr 10, 2023

Please review a small patch, fixing extraneous right braces in field javadocs of BSM_EXPLICIT_CAST, BSM_CLASS_DATA, and BSM_CLASS_DATA_AT.

JDK 20: https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/ConstantDescs.html#BSM_EXPLICIT_CAST
JDK 21: https://download.java.net/java/early_access/jdk21/docs/api/java.base/java/lang/constant/ConstantDescs.html#field-summary
With this patch: https://cr.openjdk.org/~liach/8305807/java.base/java/lang/constant/ConstantDescs.html#field-summary


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305807: Spurious right brace in ConstantDescs field Javadocs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13410/head:pull/13410
$ git checkout pull/13410

Update a local copy of the PR:
$ git checkout pull/13410
$ git pull https://git.openjdk.org/jdk.git pull/13410/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13410

View PR using the GUI difftool:
$ git pr show -t 13410

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13410.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2023

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 10, 2023
@openjdk
Copy link

openjdk bot commented Apr 10, 2023

@liach The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 10, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 10, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 10, 2023

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305807: Spurious right brace in ConstantDescs field Javadocs

Reviewed-by: mchung, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 2aeb0e5: 6241286: (cal) API: Calendar.DAY_OF_WEEK definition is wrong
  • 42965d3: 6218123: (cal) API: Spec for GregorianCalendar constructors and Calendar getInstance is inconsistent.
  • a43a17c: 8305808: Typo in javadoc of ConstantDescs::BSM_VARHANDLE_STATIC_FIELD

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung, @irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 10, 2023
@liach
Copy link
Member Author

liach commented Apr 10, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 10, 2023
@openjdk
Copy link

openjdk bot commented Apr 10, 2023

@liach
Your change (at version aeca71f) is now ready to be sponsored by a Committer.

@mlchung
Copy link
Member

mlchung commented Apr 10, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 10, 2023

Going to push as commit 0ff2ff6.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 2aeb0e5: 6241286: (cal) API: Calendar.DAY_OF_WEEK definition is wrong
  • 42965d3: 6218123: (cal) API: Spec for GregorianCalendar constructors and Calendar getInstance is inconsistent.
  • a43a17c: 8305808: Typo in javadoc of ConstantDescs::BSM_VARHANDLE_STATIC_FIELD

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 10, 2023
@openjdk openjdk bot closed this Apr 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 10, 2023
@openjdk
Copy link

openjdk bot commented Apr 10, 2023

@mlchung @liach Pushed as commit 0ff2ff6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@liach liach deleted the constdesc-brace-typo branch May 7, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants