-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8305807: Spurious right brace in ConstantDescs field Javadocs #13410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
|
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung, @irisclark) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
/sponsor |
|
Going to push as commit 0ff2ff6.
Your commit was automatically rebased without conflicts. |
Please review a small patch, fixing extraneous right braces in field javadocs of BSM_EXPLICIT_CAST, BSM_CLASS_DATA, and BSM_CLASS_DATA_AT.
JDK 20: https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/ConstantDescs.html#BSM_EXPLICIT_CAST
JDK 21: https://download.java.net/java/early_access/jdk21/docs/api/java.base/java/lang/constant/ConstantDescs.html#field-summary
With this patch: https://cr.openjdk.org/~liach/8305807/java.base/java/lang/constant/ConstantDescs.html#field-summary
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13410/head:pull/13410$ git checkout pull/13410Update a local copy of the PR:
$ git checkout pull/13410$ git pull https://git.openjdk.org/jdk.git pull/13410/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13410View PR using the GUI difftool:
$ git pr show -t 13410Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13410.diff
Webrev
Link to Webrev Comment