8305079: Remove finalize() from compiler/c2/Test719030

[afshin-zafari]

The finalize() method is replaced by a Cleaner callback.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305079: Remove finalize() from compiler/c2/Test719030

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13418/head:pull/13418
$ git checkout pull/13418

Update a local copy of the PR:
$ git checkout pull/13418
$ git pull https://git.openjdk.org/jdk.git pull/13418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13418

View PR using the GUI difftool:
$ git pr show -t 13418

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13418.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back afshin-zafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (655366f2)

[TobiHartmann]

Looks good to me.

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305079: Remove finalize() from compiler/c2/Test719030

Reviewed-by: thartmann, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 310 new commits pushed to the master branch:

• 1be80a4: 8287087: C2: perform SLP reduction analysis on-demand
• ba43649: 8306976: UTIL_REQUIRE_SPECIAL warning on grep
• cbccc4c: 8304265: Implementation of Foreign Function and Memory API (Third Preview)
• 41d5853: 8306940: test/jdk/java/net/httpclient/XxxxInURI.java should call HttpClient::close
• d94ce65: 8306858: Remove some remnants of CMS from SA agent
• a83c02f: 8306654: Disable NMT location_printing_cheap_dead_xx tests again
• de0c05d: 6995195: Static initialization deadlock in sun.java2d.loops.Blit and GraphicsPrimitiveMgr
• 748476f: 8306732: TruncatedSeq::predict_next() attempts linear regression with only one data point
• 27c5c10: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
• 9ebcda2: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
• ... and 300 more: https://git.openjdk.org/jdk/compare/a663d5d69486447d80cab040830abf0b11636c8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @coleenp) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[coleenp]

This looks good!

[afshin-zafari]

Thank you for your reviews.
/integrate

[openjdk]

@afshin-zafari
Your change (at version 655366f) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 84df74c.
Since your change was applied there have been 322 commits pushed to the master branch:

• 0b5c504: 8306696: Remove MetaspaceReclaimPolicy=aggressive and obsolete MetaspaceReclaimPolicy
• eb3af8a: 8306901: Macro offset_of confuses Eclipse CDT
• d3abfec: 8305566: Change StringDedup thread to derive from JavaThread
• f3c90f0: 8306711: Improve diagnosis of IntlTest framework
• b827ce8: 8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails
• 7871390: 8306952: improve generic signature of internal DCInlineTag class
• 6983d05: 8306927: Collator treats "v" and "w" as the same letter for Swedish language locale.
• 80fae51: 8306959: (bf) CharBuffer.append(CharSequence,int,int) throws BufferOverflowException where IndexOutOfBoundsException expected
• eb35861: 8205592: BigDecimal.doubleValue() is depressingly slow
• 41ba05e: 8306850: Open source AWT Model related tests
• ... and 312 more: https://git.openjdk.org/jdk/compare/a663d5d69486447d80cab040830abf0b11636c8f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @afshin-zafari Pushed as commit 84df74c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.