8305847: Improve diagnosability and resilience of HttpClient::close tests

[dfuch]

The HttpClient close tests could be improved to provide better diagnosis.

The tests make some requests and register some dependent actions to check the response state, followed by some dependent action that will read the request body (from an input stream). But if the first dependent action asserts, the second will not be executed, and the body will neither be read or closed.
This will later prevent HttpClient::close method, or the HttpClient::awaitTermination method, to terminate as expected, and the test will then later fail in timeout (either from jtreg or awaitTermination). This behaviour can be confusing for failure analysis.

The tests could also be further simplified by creating the executor in which the responses bodies will eventually be read (called readerService) in the setup() method and later close it in teardown(). This will simplify the cleanup phase, and ensure the service does not get closed until all dependent actions have been scheduled.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305847: Improve diagnosability and resilience of HttpClient::close tests

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Daniel Jeliński (@djelinski - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13426/head:pull/13426
$ git checkout pull/13426

Update a local copy of the PR:
$ git checkout pull/13426
$ git pull https://git.openjdk.org/jdk.git pull/13426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13426

View PR using the GUI difftool:
$ git pr show -t 13426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13426.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2f2af1e0)

[jaikiran]

Hello Daniel, the changes look fine to me.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305847: Improve diagnosability and resilience of HttpClient::close tests

Reviewed-by: jpai, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 6b9b7d1: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0
• 2060c8e: 8305688: jdk build --with-memory-size=1024 broken by JDK-8305100
• 646b666: 8305900: Use loopback IP addresses in security policy files of httpclient tests
• fb9a29d: 8305414: gtest/NMTGtests.java is failing various sub-tests
• e846a1d: 8304450: [vectorapi] Refactor VectorShuffle implementation
• 3f36dd8: 8305529: DefaultProxySelector.select(URI) in certain cases returns a List with null element
• 425ef06: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries
• 2bbbff2: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries
• bc15163: 8304834: Fix wrapper insertion in TestScaffold.parseArgs(String args[])
• 19380d7: 8305324: C2: Wrong execution of vectorizing Interger.reverseBytes
• ... and 18 more: https://git.openjdk.org/jdk/compare/cd7d53c88c27eedbe16020b88c2219708d170a1e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dfuch]

/integrate

[openjdk]

Going to push as commit 90b4006.
Since your change was applied there have been 30 commits pushed to the master branch:

• d7dc474: 8305712: [MacOS] Deprecated Cocoa-NSEvent names
• e0620b8: 8296420: javac has long lines in its command-line help
• 6b9b7d1: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0
• 2060c8e: 8305688: jdk build --with-memory-size=1024 broken by JDK-8305100
• 646b666: 8305900: Use loopback IP addresses in security policy files of httpclient tests
• fb9a29d: 8305414: gtest/NMTGtests.java is failing various sub-tests
• e846a1d: 8304450: [vectorapi] Refactor VectorShuffle implementation
• 3f36dd8: 8305529: DefaultProxySelector.select(URI) in certain cases returns a List with null element
• 425ef06: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries
• 2bbbff2: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries
• ... and 20 more: https://git.openjdk.org/jdk/compare/cd7d53c88c27eedbe16020b88c2219708d170a1e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit 90b4006.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.