Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305892: G1: Fix G1MMUTracker::when_sec documentation #13441

Closed
wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Apr 12, 2023

Trivial comment-only change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305892: G1: Fix G1MMUTracker::when_sec documentation

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13441/head:pull/13441
$ git checkout pull/13441

Update a local copy of the PR:
$ git checkout pull/13441
$ git pull https://git.openjdk.org/jdk.git pull/13441/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13441

View PR using the GUI difftool:
$ git pr show -t 13441

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13441.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8305892 8305892: G1: Fix G1MMUTracker::when_sec documentation Apr 12, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 12, 2023
@openjdk
Copy link

openjdk bot commented Apr 12, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 12, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 17, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305892: G1: Fix G1MMUTracker::when_sec documentation

Reviewed-by: iwalulya, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • c0b4957: 8305740: C2: add print statements to assert: Can't determine return type.
  • 5c95bb1: 8257967: JFR: Events for loaded agents
  • 2a062f1: 8305089: Implement missing socket options on AIX
  • 7f56de8: 8306036: Use @APinote in String.toLowerCase, String.toUpperCase
  • e575924: 8305336: java.security.debug=sunpkcs11 breaks PKCS#11 configuration with slotListIndex
  • caa841d: 8306029: ProblemList runtime/ErrorHandling/TestDwarf.java on linux
  • 314bad3: 8305935: Resolve multiple definition of 'jmm_<interface|version>' when statically linking with JDK native libraries
  • 793da60: 8305403: Shenandoah evacuation workers may deadlock
  • 2cc4bf1: 8305085: Suppress removal warning for finalize() from test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineFinalizer.java
  • 5a78865: 8304930: Enable Link Time Optimization as an option for Visual C++
  • ... and 31 more: https://git.openjdk.org/jdk/compare/d8af7a6014055295355a1242db6c2872299c6398...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2023
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial. Fwiw I fixed one additional typo.

src/hotspot/share/gc/g1/g1MMUTracker.cpp Outdated Show resolved Hide resolved
Co-authored-by: Thomas Schatzl <59967451+tschatzl@users.noreply.github.com>
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 17, 2023

Going to push as commit dbd2b5f.
Since your change was applied there have been 41 commits pushed to the master branch:

  • c0b4957: 8305740: C2: add print statements to assert: Can't determine return type.
  • 5c95bb1: 8257967: JFR: Events for loaded agents
  • 2a062f1: 8305089: Implement missing socket options on AIX
  • 7f56de8: 8306036: Use @APinote in String.toLowerCase, String.toUpperCase
  • e575924: 8305336: java.security.debug=sunpkcs11 breaks PKCS#11 configuration with slotListIndex
  • caa841d: 8306029: ProblemList runtime/ErrorHandling/TestDwarf.java on linux
  • 314bad3: 8305935: Resolve multiple definition of 'jmm_<interface|version>' when statically linking with JDK native libraries
  • 793da60: 8305403: Shenandoah evacuation workers may deadlock
  • 2cc4bf1: 8305085: Suppress removal warning for finalize() from test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineFinalizer.java
  • 5a78865: 8304930: Enable Link Time Optimization as an option for Visual C++
  • ... and 31 more: https://git.openjdk.org/jdk/compare/d8af7a6014055295355a1242db6c2872299c6398...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 17, 2023
@openjdk openjdk bot closed this Apr 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2023
@openjdk
Copy link

openjdk bot commented Apr 17, 2023

@albertnetymk Pushed as commit dbd2b5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-mmu-doc branch April 17, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants