8305404: Compile_lock not needed for InstanceKlass::implementor()

[coleenp]

See CR for details.
Tested with tier1-4, 7, 8.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305404: Compile_lock not needed for InstanceKlass::implementor()

Reviewers

• Erik Österlund (@fisk - Reviewer)
• Frederic Parain (@fparain - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13458/head:pull/13458
$ git checkout pull/13458

Update a local copy of the PR:
$ git checkout pull/13458
$ git pull https://git.openjdk.org/jdk.git pull/13458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13458

View PR using the GUI difftool:
$ git pr show -t 13458

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13458.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (76c4aa8a)

[coleenp]

/assign @fisk

[openjdk]

@coleenp Unknown command assign - for a list of valid commands use /help.

[fisk]

Looks good.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305404: Compile_lock not needed for InstanceKlass::implementor()

Reviewed-by: eosterlund, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• d2ce04b: 8301496: Replace NULL with nullptr in cpu/riscv
• 54bf370: 8170945: Collectors$Partition should override more Map methods
• 0826cee: 8301495: Replace NULL with nullptr in cpu/ppc
• c0c3122: 8305618: Move gcold out of tier1
• 3651b92: 8305944: assert(is_aligned(ref, HeapWordSize)) failed: invariant
• 12358e6: 8305934: PPC64: Disable VMContinuations on Big Endian
• 287bb06: 8305902: (cs) Resolve default Charset only once in StreamEncoder and StreamDecoder
• 8a1639d: 8305936: JavaThread::create_system_thread_object has unused is_visible argument
• 76cda9f: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext
• b60604e: 8305794: Unused interface sun.security.util.PermissionFactory can be removed
• ... and 6 more: https://git.openjdk.org/jdk/compare/6b9b7d1d921367418f82c2813b272d3447a47595...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Erik!

[coleenp]

Thanks Fred!
/integrate

[openjdk]

Going to push as commit ebeee6d.
Since your change was applied there have been 16 commits pushed to the master branch:

• d2ce04b: 8301496: Replace NULL with nullptr in cpu/riscv
• 54bf370: 8170945: Collectors$Partition should override more Map methods
• 0826cee: 8301495: Replace NULL with nullptr in cpu/ppc
• c0c3122: 8305618: Move gcold out of tier1
• 3651b92: 8305944: assert(is_aligned(ref, HeapWordSize)) failed: invariant
• 12358e6: 8305934: PPC64: Disable VMContinuations on Big Endian
• 287bb06: 8305902: (cs) Resolve default Charset only once in StreamEncoder and StreamDecoder
• 8a1639d: 8305936: JavaThread::create_system_thread_object has unused is_visible argument
• 76cda9f: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext
• b60604e: 8305794: Unused interface sun.security.util.PermissionFactory can be removed
• ... and 6 more: https://git.openjdk.org/jdk/compare/6b9b7d1d921367418f82c2813b272d3447a47595...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit ebeee6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.