8303422: Use common functions to exit the VM for -Xshare:dump and CDS errors

[matias9927]

Currently, we have ad-hoc calls to os::_exit(0), vm_exit_during_initialization() and vm_direct_exit() in cases where there are dumptime or runtime errors for CDS. This patch introduces intuitively named methods for exiting the VM when there are dumptime/runtime errors and when dumping is finished. Verified with tier 1-4 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303422: Use common functions to exit the VM for -Xshare:dump and CDS errors

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to 2cf19cee
• Frederic Parain (@fparain - Reviewer) ⚠️ Review applies to 2cf19cee

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13463/head:pull/13463
$ git checkout pull/13463

Update a local copy of the PR:
$ git checkout pull/13463
$ git pull https://git.openjdk.org/jdk.git pull/13463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13463

View PR using the GUI difftool:
$ git pr show -t 13463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13463.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (756a955e)
• 04: Full - Incremental (2cf19cee)
• 03: Full - Incremental (e6a14c0e)
• 02: Full - Incremental (158fa0c6)
• 01: Full - Incremental (a2214143)
• 00: Full (a533e86e)

[coleenp]

This looks good with the additional comments above the new functions.

[openjdk]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303422: Use common functions to exit the VM for -Xshare:dump and CDS errors

Reviewed-by: iklam, coleenp, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• 8858d54: 8305811: (bf) Improve performance of CharBuffer::append(CharSequence[,int,int])
• 525a91e: 8305673: Convert DocCommentParser to use enhanced switch
• 6831f9d: 8278583: Open source SwingMark - Swing performance benchmark
• 497f9e7: 8305755: [JVMCI] missing barriers in CompilerToVM.readFieldValue for Reference.referent
• 4ed933c: 8296248: Update CLDR to Version 43.0
• 7360960: 8305625: Stress test crashes with SEGV in Deoptimization::deoptimize_frame_internal(JavaThread*, long*, Deoptimization::DeoptReason)
• cc60f2f: 8305060: G1: Refactor G1ScanHRForRegionClosure::scan_heap_roots
• fb58d77: 8305192: serial GC fails "assert(Universe::on_page_boundary(bottom) && Universe::on_page_boundary(end)) failed: invalid space boundaries"
• 7551529: 8305995: Footprint regression from JDK-8224957
• 02347d0: 8305351: C2 setScopedValueCache intrinsic doesn't use access API
• ... and 32 more: https://git.openjdk.org/jdk/compare/6b9b7d1d921367418f82c2813b272d3447a47595...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

Looks good to me. Just one nit.

[matias9927]

Thank you for the feedback and reviews @coleenp, @fparain, and @iklam!
/integrate

[openjdk]

Going to push as commit e3ece36.
Since your change was applied there have been 43 commits pushed to the master branch:

• bb1a7bb: 8305762: FileInputStream and FileOutputStream implSpec should be corrected or removed
• 8858d54: 8305811: (bf) Improve performance of CharBuffer::append(CharSequence[,int,int])
• 525a91e: 8305673: Convert DocCommentParser to use enhanced switch
• 6831f9d: 8278583: Open source SwingMark - Swing performance benchmark
• 497f9e7: 8305755: [JVMCI] missing barriers in CompilerToVM.readFieldValue for Reference.referent
• 4ed933c: 8296248: Update CLDR to Version 43.0
• 7360960: 8305625: Stress test crashes with SEGV in Deoptimization::deoptimize_frame_internal(JavaThread*, long*, Deoptimization::DeoptReason)
• cc60f2f: 8305060: G1: Refactor G1ScanHRForRegionClosure::scan_heap_roots
• fb58d77: 8305192: serial GC fails "assert(Universe::on_page_boundary(bottom) && Universe::on_page_boundary(end)) failed: invalid space boundaries"
• 7551529: 8305995: Footprint regression from JDK-8224957
• ... and 33 more: https://git.openjdk.org/jdk/compare/6b9b7d1d921367418f82c2813b272d3447a47595...master

Your commit was automatically rebased without conflicts.

[openjdk]

@matias9927 Pushed as commit e3ece36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.