-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296248: Update CLDR to Version 43.0 #13469
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
/label remove build |
@naotoj |
Webrevs
|
</languages> | ||
</localeDisplayNames> | ||
<characters> | ||
<exemplarCharacters>[a á à ǎ b c d e é è ě ɛ {ɛ\u0301} {ɛ\u0300} {ɛ\u030C} f g {gb} {gh} h i ɨ {ɨ\u0301} {ɨ\u0300} {ɨ\u030C} j k {kp} m n {ny} ŋ o ó ò ǒ ɔ {ɔ\u0301} {ɔ\u0300} {ɔ\u030C} p r s t u ú ù ǔ ʉ {ʉ\u0301} {ʉ\u0300} {ʉ\u030C} w y]</exemplarCharacters> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naotoj this is in common/main but not at basic level… is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JDK keeps CLDR sources intact. On building JDK, .xml files are transformed into ResourceBundles and those not at the basic level are filtered out.
so ; modern ; Somali | ||
sq ; modern ; Albanian | ||
sr ; modern ; Serbian | ||
sr_Latn ; modern ; Serbian (Latin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naotoj BTW this was fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The patch before was removed with this commit: 0e3456c
@@ -1,4 +1,4 @@ | |||
## Unicode Common Local Data Repository (CLDR) v42 | |||
## Unicode Common Local Data Repository (CLDR) v43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW the license is now just named LICENSE
in the repo starting with v44
|
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 4ed933c.
Your commit was automatically rebased without conflicts. |
Upgrading the CLDR to version 43. This semi-annual release is their
limited-submission
release so I would not expect regressions caused by formatting changes as we had in JDK20/CLDRv42 (https://inside.java/2023/03/28/quality-heads-up/)Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13469/head:pull/13469
$ git checkout pull/13469
Update a local copy of the PR:
$ git checkout pull/13469
$ git pull https://git.openjdk.org/jdk.git pull/13469/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13469
View PR using the GUI difftool:
$ git pr show -t 13469
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13469.diff
Webrev
Link to Webrev Comment