Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296248: Update CLDR to Version 43.0 #13469

Closed
wants to merge 16 commits into from
Closed

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Apr 13, 2023

Upgrading the CLDR to version 43. This semi-annual release is their limited-submission release so I would not expect regressions caused by formatting changes as we had in JDK20/CLDRv42 (https://inside.java/2023/03/28/quality-heads-up/)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13469/head:pull/13469
$ git checkout pull/13469

Update a local copy of the PR:
$ git checkout pull/13469
$ git pull https://git.openjdk.org/jdk.git pull/13469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13469

View PR using the GUI difftool:
$ git pr show -t 13469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13469.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 13, 2023
@openjdk
Copy link

openjdk bot commented Apr 13, 2023

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Apr 13, 2023
@naotoj
Copy link
Member Author

naotoj commented Apr 13, 2023

/label remove build

@openjdk openjdk bot removed the build build-dev@openjdk.org label Apr 13, 2023
@openjdk
Copy link

openjdk bot commented Apr 13, 2023

@naotoj
The build label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented Apr 13, 2023

Webrevs

</languages>
</localeDisplayNames>
<characters>
<exemplarCharacters>[a á à ǎ b c d e é è ě ɛ {ɛ\u0301} {ɛ\u0300} {ɛ\u030C} f g {gb} {gh} h i ɨ {ɨ\u0301} {ɨ\u0300} {ɨ\u030C} j k {kp} m n {ny} ŋ o ó ò ǒ ɔ {ɔ\u0301} {ɔ\u0300} {ɔ\u030C} p r s t u ú ù ǔ ʉ {ʉ\u0301} {ʉ\u0300} {ʉ\u030C} w y]</exemplarCharacters>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naotoj this is in common/main but not at basic level… is this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK keeps CLDR sources intact. On building JDK, .xml files are transformed into ResourceBundles and those not at the basic level are filtered out.

so ; modern ; Somali
sq ; modern ; Albanian
sr ; modern ; Serbian
sr_Latn ; modern ; Serbian (Latin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naotoj BTW this was fixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The patch before was removed with this commit: 0e3456c

@@ -1,4 +1,4 @@
## Unicode Common Local Data Repository (CLDR) v42
## Unicode Common Local Data Repository (CLDR) v43
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW the license is now just named LICENSE in the repo starting with v44

@srl295
Copy link
Member

srl295 commented Apr 13, 2023

@srl295 (no known openjdk.org user name / role) 😢

@openjdk
Copy link

openjdk bot commented Apr 14, 2023

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296248: Update CLDR to Version 43.0

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 1fd4006: 8305405: Compile_lock not needed in Universe::genesis()
  • ebeee6d: 8305404: Compile_lock not needed for InstanceKlass::implementor()
  • d2ce04b: 8301496: Replace NULL with nullptr in cpu/riscv
  • 54bf370: 8170945: Collectors$Partition should override more Map methods
  • 0826cee: 8301495: Replace NULL with nullptr in cpu/ppc
  • c0c3122: 8305618: Move gcold out of tier1
  • 3651b92: 8305944: assert(is_aligned(ref, HeapWordSize)) failed: invariant
  • 12358e6: 8305934: PPC64: Disable VMContinuations on Big Endian
  • 287bb06: 8305902: (cs) Resolve default Charset only once in StreamEncoder and StreamDecoder
  • 8a1639d: 8305936: JavaThread::create_system_thread_object has unused is_visible argument
  • ... and 2 more: https://git.openjdk.org/jdk/compare/92521b100f1eb785eabd101870f631f555c3b135...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 14, 2023
@naotoj
Copy link
Member Author

naotoj commented Apr 17, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 17, 2023

Going to push as commit 4ed933c.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 7360960: 8305625: Stress test crashes with SEGV in Deoptimization::deoptimize_frame_internal(JavaThread*, long*, Deoptimization::DeoptReason)
  • cc60f2f: 8305060: G1: Refactor G1ScanHRForRegionClosure::scan_heap_roots
  • fb58d77: 8305192: serial GC fails "assert(Universe::on_page_boundary(bottom) && Universe::on_page_boundary(end)) failed: invalid space boundaries"
  • 7551529: 8305995: Footprint regression from JDK-8224957
  • 02347d0: 8305351: C2 setScopedValueCache intrinsic doesn't use access API
  • 2240c7e: 8305543: Ensure GC barriers for arraycopy on AArch64 use caller saved neon temp registers
  • 1958f0e: 8305233: G1: Refactor G1ClearCardTableTask
  • dbd2b5f: 8305892: G1: Fix G1MMUTracker::when_sec documentation
  • c0b4957: 8305740: C2: add print statements to assert: Can't determine return type.
  • 5c95bb1: 8257967: JFR: Events for loaded agents
  • ... and 21 more: https://git.openjdk.org/jdk/compare/92521b100f1eb785eabd101870f631f555c3b135...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 17, 2023
@openjdk openjdk bot closed this Apr 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2023
@openjdk
Copy link

openjdk bot commented Apr 17, 2023

@naotoj Pushed as commit 4ed933c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
3 participants