Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256740: ZGC: Move closures out of zOopClosure files #1347

Closed
wants to merge 1 commit into from

Conversation

stefank
Copy link
Member

@stefank stefank commented Nov 20, 2020

zOopClosures.hpp and zOopClosures.inline.hpp contain a collection of different closures. There used to be a need to split closures and have them registered with the oop iterate framework, but that has been fixed with the last oop iterate framework rewrite.

I propose that we move the closures out to the sub-systems where they are used.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux aarch64 Linux arm Linux ppc64le Linux s390x Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (6/6 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) (1/9 failed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8256740: ZGC: Move closures out of zOopClosure files

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1347/head:pull/1347
$ git checkout pull/1347

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 20, 2020

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 20, 2020

@stefank The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 20, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 20, 2020

Webrevs

pliden
pliden approved these changes Nov 20, 2020
Copy link
Contributor

@pliden pliden left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Nov 20, 2020

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256740: ZGC: Move closures out of zOopClosure files

Reviewed-by: pliden

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • ff00c59: 8256569: Add C2 compiler stress flags to CTW
  • e7c7469: 8246378: [Windows] assert on MethodHandle logging code
  • 98a5d5a: 8256664: Shenandoah: Cleanup after JDK-8212879
  • b99fd4c: 8033441: print line numbers with -XX:+PrintOptoAssembly
  • 266dea0: 8256688: Shenandoah: Lock rank inversion after JDK-8212879
  • aeba925: 8256416: ZGC: Lower ZMarkCompleteTimeout

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 20, 2020
@stefank
Copy link
Member Author

@stefank stefank commented Nov 23, 2020

Thanks for reviewing!

@stefank
Copy link
Member Author

@stefank stefank commented Nov 23, 2020

/integrate

@openjdk openjdk bot closed this Nov 23, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2020

@stefank Since your change was applied there have been 30 commits pushed to the master branch:

  • 659aec8: 8256719: C1 flags that should have expired are still present
  • e06a683: 8256497: Zero: enable G1 and Shenandoah GCs
  • 037e49c: 8256670: Zero: enable compressed oops support back
  • d46f6f5: 8256523: Streamline Java SHA2 implementation
  • 1aa90ac: 8256822: runtime/logging/RedefineClasses.java fails with "Error: VM option 'Verbose' is develop and is available only in debug version of VM."
  • edf72f0: 8256824: test/langtools/tools/javac/diags/examples/InnerClassCantHaveStatic.java has a bad copyright
  • 9a19eb6: 8254105: allow static nested declarations
  • 14de791: 8255934: JConsole 14 and greater fails to connect to older JVM
  • 86f3602: 8256806: Shenandoah: optimize shenandoah/jni/TestPinnedGarbage.java test
  • 57025e6: 8256073: Improve vector rematerialization support
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/10ba5418465c5d3280b7113d6b902b6d4b5ca533...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1f32c11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stefank stefank deleted the 8256740_zoopclosure branch Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
2 participants