JDK-8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message

[MBaesken]

Currently we get a rather strange exception in our jtreg tests :

java/nio/channels/DatagramChannel/AdaptorMulticasting.java

java.net.SocketException: Exec format error
at java.base/sun.nio.ch.Net.joinOrDrop4(Native Method)
at java.base/sun.nio.ch.Net.join4(Net.java:708)
at java.base/sun.nio.ch.DatagramChannelImpl.innerJoin(DatagramChannelImpl.java:1606)
at java.base/sun.nio.ch.DatagramChannelImpl.join(DatagramChannelImpl.java:1624)
at Promiscuous.test(Promiscuous.java:176)
at Promiscuous.main(Promiscuous.java:223)

The message could at least be improved, saying that setsockopt failed (plus providing the errno related text).
Example is seen on macOS btw. .

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13472/head:pull/13472
$ git checkout pull/13472

Update a local copy of the PR:
$ git checkout pull/13472
$ git pull https://git.openjdk.org/jdk.git pull/13472/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13472

View PR using the GUI difftool:
$ git pr show -t 13472

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13472.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (46ba11da)
• 00: Full (811003c5)

[AlanBateman]

This looks okay but we should probably put the function prototype at the top rather in the middle of the JNI functions. I guess it can be static too.

[MBaesken]

Hi Alan, thanks for the comment; I moved the function up in the file.

[AlanBateman]

Hi Alan, thanks for the comment; I moved the function up in the file.

My comment was to actually to move the function prototype as the first iteration put it in the middle of the JNI functions, which looks very strange. Moving handleSocketErrorWithXXX to the top is okay, I can live with that.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• 3c7ab80: 8304054: Linux: NullPointerException from FontConfiguration.getVersion in case no fonts are installed
• 3bba899: 8299592: Fix and reenable warnings in java.desktop native code compilation
• 896207d: 8306077: Replace NEW_ARENA_ARRAY with NEW_RESOURCE_ARRAY when applicable in opto
• 54f7b6c: 8301497: Replace NULL with nullptr in cpu/s390
• 8ecb5df: 8305781: compiler/c2/irTests/TestVectorizationMultiInvar.java failed with "IRViolationException: There were one or multiple IR rule failures."
• 49726ee: 8305690: [X86] Do not emit two REX prefixes in Assembler::prefix
• 445ebef: 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2
• e3ece36: 8303422: Use common functions to exit the VM for -Xshare:dump and CDS errors
• bb1a7bb: 8305762: FileInputStream and FileOutputStream implSpec should be corrected or removed
• 8858d54: 8305811: (bf) Improve performance of CharBuffer::append(CharSequence[,int,int])
• ... and 30 more: https://git.openjdk.org/jdk/compare/12358e6c94bc96e618efc3ec5299a2cfe1b4669d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[MBaesken]

Hi Alan, thanks for the review !

/integrate

[openjdk]

Going to push as commit ebba42a.
Since your change was applied there have been 58 commits pushed to the master branch:

• 42b7260: 8306111: PPC64: RT call after thaw with exception requires larger ABI section
• c7faf60: 8305757: Call Method::compute_has_loops_flag() when creating CDS archive
• eb8d8cd: 8299129: Enhance NameService lookups
• 77df315: 8296692: Improve String platform support
• f098b49: 8298310: Enhance TLS session negotiation
• 9e56d10: 8296832: Improve Swing platform support
• 2e5700a: 8288436: Improve Xalan supports
• b1c34c0: 8296684: Improve String platform support
• 14aad78: 8294474: Better AES support
• a0f7ae1: 8298667: Improved path handling
• ... and 48 more: https://git.openjdk.org/jdk/compare/12358e6c94bc96e618efc3ec5299a2cfe1b4669d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit ebba42a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.