Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB #13480

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Apr 14, 2023

Modify the disk space verification to retrieve the expected value dynamically as the first parameter of the check method, as is done for the value being tested.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13480/head:pull/13480
$ git checkout pull/13480

Update a local copy of the PR:
$ git checkout pull/13480
$ git pull https://git.openjdk.org/jdk.git pull/13480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13480

View PR using the GUI difftool:
$ git pr show -t 13480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13480.diff

Webrev

Link to Webrev Comment

….RuntimeException: values differ by more than 1GB
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2023
@openjdk
Copy link

openjdk bot commented Apr 14, 2023

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Apr 14, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 14, 2023

Webrevs

@bplb bplb changed the title 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.langRuntimeException: values differ by more than 1GB 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB May 8, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2023

@bplb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bplb
Copy link
Member Author

bplb commented May 13, 2023

ping

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the logs in the comments in the JBS, it appears that the sizes changed between the time the size values were captured and the check was run.
Fetching the size when doing the check, as being proposed in this PR, looks reasonable to me and it doesn't change what was previously being tested - the comparison of values returned by size APIs on java.io.File and java.nio.file.FileStore.

@openjdk
Copy link

openjdk bot commented May 16, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB

Reviewed-by: jpai, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 523 new commits pushed to the master branch:

  • 23cbb2d: 8306860: Avoid unnecessary allocation in List.map() when list is empty
  • be54b54: 8307369: Add execution of all svc tests in CI
  • 19c8c30: 8305634: Renaming predicates, simple cleanups, and adding summary about current predicates
  • 72294c5: 8308024: HttpClient (HTTP/1.1) sends an extraneous empty chunk if the BodyPublisher supplies an empty buffer
  • c9b6bb5: 8308041: [JVMCI] WB_IsGCSupportedByJVMCICompiler must enter correct JVMCI env
  • 0790f70: 8306806: JMX agent with JDP enabled won't start when PerfData is disabled
  • c2ef302: 8307968: serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java timed out
  • d22bcc8: 8307403: java/util/zip/DeInflate.java timed out
  • 2210e06: 8306638: Open source some AWT tests related to datatransfer and Toolkit
  • 05b51c7: 8307567: Avoid relocating global roots to metaspaceObjs in CDS dump
  • ... and 513 more: https://git.openjdk.org/jdk/compare/ba90dc77958c399e4e1fc3c4999dd76680480c7b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 16, 2023
Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bplb
Copy link
Member Author

bplb commented May 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 19, 2023

Going to push as commit a5343fa.
Since your change was applied there have been 581 commits pushed to the master branch:

  • 44218b1: 8308248: Revisit alignment of layout constants on 32-bit platforms
  • 80ef5c2: 8308410: broken compilation of test\jdk\tools\launcher\exeJliLaunchTest.c
  • 326d778: 8306057: False arguments calling dispatch_base for aarch64
  • 690d396: 8308408: Build failure with -Werror=maybe-uninitialized in libjli/java.c with GCC8
  • fa14314: 8303669: SelectVersion indexes past the end of the argv array
  • 25868b9: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage
  • 6765761: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey
  • 97ade57: 8307609: RISC-V: Added support for Extract, Compress, Expand and other nodes for Vector API
  • e520cdc: 8308277: RISC-V: Improve vectorization of Match.sqrt() on floats
  • 42948c0: 8307865: Invalid is_in_any_VTMS_transition() check in post_dynamic_code_generated_while_holding_locks
  • ... and 571 more: https://git.openjdk.org/jdk/compare/ba90dc77958c399e4e1fc3c4999dd76680480c7b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 19, 2023
@openjdk openjdk bot closed this May 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2023
@openjdk
Copy link

openjdk bot commented May 19, 2023

@bplb Pushed as commit a5343fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the FileStore-Basic-8281149 branch May 25, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
3 participants