Skip to content

8306279: Build failure after JDK-8299592 #13507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Apr 18, 2023

Please review this patch that disables a warning that appeared on linux builds in slowdebug configuration after JDK-8299592.

I plan to investigate why this failure appears only in slowdebug mode; this patch is intended to unblock the CI.

Verified that the slowdebug builds pass with this patch applied.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13507/head:pull/13507
$ git checkout pull/13507

Update a local copy of the PR:
$ git checkout pull/13507
$ git pull https://git.openjdk.org/jdk.git pull/13507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13507

View PR using the GUI difftool:
$ git pr show -t 13507

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13507.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2023

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2023
@openjdk
Copy link

openjdk bot commented Apr 18, 2023

@djelinski The following labels will be automatically applied to this pull request:

  • build
  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org client client-libs-dev@openjdk.org labels Apr 18, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2023

Webrevs

@djelinski
Copy link
Member Author

note: before JDK-8299592 all warnings in debug_mem.c were disabled, so this particular warning is not new.

@djelinski
Copy link
Member Author

GHA failures unrelated (JDK-8306282)

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@openjdk
Copy link

openjdk bot commented Apr 18, 2023

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306279: Build failure after JDK-8299592

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 18, 2023
@djelinski
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 18, 2023

Going to push as commit e97fe08.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2023
@openjdk openjdk bot closed this Apr 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2023
@openjdk
Copy link

openjdk bot commented Apr 18, 2023

@djelinski Pushed as commit e97fe08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the disable-awt-warning branch April 18, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants