-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8306279: Build failure after JDK-8299592 #13507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into |
@djelinski The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
note: before JDK-8299592 all warnings in debug_mem.c were disabled, so this particular warning is not new. |
GHA failures unrelated (JDK-8306282) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
@djelinski This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit e97fe08. |
@djelinski Pushed as commit e97fe08. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this patch that disables a warning that appeared on linux builds in slowdebug configuration after JDK-8299592.
I plan to investigate why this failure appears only in slowdebug mode; this patch is intended to unblock the CI.
Verified that the slowdebug builds pass with this patch applied.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13507/head:pull/13507
$ git checkout pull/13507
Update a local copy of the PR:
$ git checkout pull/13507
$ git pull https://git.openjdk.org/jdk.git pull/13507/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13507
View PR using the GUI difftool:
$ git pr show -t 13507
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13507.diff
Webrev
Link to Webrev Comment