Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Apr 18, 2023

Trivial fix to use SIZE_FORMAT where needed.

Testing:

  • 32-bit builds in GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13511/head:pull/13511
$ git checkout pull/13511

Update a local copy of the PR:
$ git checkout pull/13511
$ git pull https://git.openjdk.org/jdk.git pull/13511/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13511

View PR using the GUI difftool:
$ git pr show -t 13511

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13511.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2023
@openjdk
Copy link

openjdk bot commented Apr 18, 2023

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 18, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2023

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Apr 18, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306289: 32-bit build failures after JDK-8303422

Reviewed-by: jiefu, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e97fe08: 8306279: Build failure after JDK-8299592
  • 3c7ab80: 8304054: Linux: NullPointerException from FontConfiguration.getVersion in case no fonts are installed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 18, 2023
Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shipilev
Copy link
Member Author

Thank you for quick reviews!

There are other failures in other configs, not related/covered by this PR. I am integrating to get cleaner 32-bit testing.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 18, 2023

Going to push as commit 803680f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • e97fe08: 8306279: Build failure after JDK-8299592
  • 3c7ab80: 8304054: Linux: NullPointerException from FontConfiguration.getVersion in case no fonts are installed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2023
@openjdk openjdk bot closed this Apr 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2023
@openjdk
Copy link

openjdk bot commented Apr 18, 2023

@shipilev Pushed as commit 803680f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8306289-32-bit branch April 18, 2023 18:30
@kimbarrett
Copy link

Late to the party, since this got reviewed and pushed so quickly. This could have used the newer "%zu" directly in
the format strings rather than the ugly SIZE_FORMAT. https://bugs.openjdk.org/browse/JDK-8256379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants