8306123: Move InstanceKlass writeable flags

[coleenp]

Please review this patch to move the writeable Klass AccessFlags to InstanceKlassFlags.
Tested with tier1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306123: Move InstanceKlass writeable flags

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Frederic Parain (@fparain - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13515/head:pull/13515
$ git checkout pull/13515

Update a local copy of the PR:
$ git checkout pull/13515
$ git pull https://git.openjdk.org/jdk.git pull/13515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13515

View PR using the GUI difftool:
$ git pr show -t 13515

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13515.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2d6fb6a2)

[iklam]

LGTM.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306123: Move InstanceKlass writeable flags

Reviewed-by: iklam, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• c738c8e: 8306278: jvmtiAgentList.cpp:253 assert(offset >= 0) failed: invariant occurs on AIX after JDK-8257967
• 9fb53ad: 8305716: Enhancements for printing age tables
• ebba42a: 8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message
• 42b7260: 8306111: PPC64: RT call after thaw with exception requires larger ABI section
• c7faf60: 8305757: Call Method::compute_has_loops_flag() when creating CDS archive
• eb8d8cd: 8299129: Enhance NameService lookups
• 77df315: 8296692: Improve String platform support
• f098b49: 8298310: Enhance TLS session negotiation
• 9e56d10: 8296832: Improve Swing platform support
• 2e5700a: 8288436: Improve Xalan supports
• ... and 25 more: https://git.openjdk.org/jdk/compare/7360960454b3116a0724396f25415f2c3bcf8930...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[fparain]

Nice clean up.
Looks good to me.

[coleenp]

Thanks Ioi and Fred.
/integrate

[openjdk]

Going to push as commit ddb8646.
Since your change was applied there have been 36 commits pushed to the master branch:

• 1a41e12: 8306310: Move is_shared Klass flag
• c738c8e: 8306278: jvmtiAgentList.cpp:253 assert(offset >= 0) failed: invariant occurs on AIX after JDK-8257967
• 9fb53ad: 8305716: Enhancements for printing age tables
• ebba42a: 8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message
• 42b7260: 8306111: PPC64: RT call after thaw with exception requires larger ABI section
• c7faf60: 8305757: Call Method::compute_has_loops_flag() when creating CDS archive
• eb8d8cd: 8299129: Enhance NameService lookups
• 77df315: 8296692: Improve String platform support
• f098b49: 8298310: Enhance TLS session negotiation
• 9e56d10: 8296832: Improve Swing platform support
• ... and 26 more: https://git.openjdk.org/jdk/compare/7360960454b3116a0724396f25415f2c3bcf8930...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit ddb8646.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.