8306135: Clean up and open source some AWT tests #13518

azuev-java · 2023-04-18T18:55:42Z

Cleaning up and open sourcing three AWT tests

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8306135: Clean up and open source some AWT tests

Reviewers

Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13518/head:pull/13518
$ git checkout pull/13518

Update a local copy of the PR:
$ git checkout pull/13518
$ git pull https://git.openjdk.org/jdk.git pull/13518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13518

View PR using the GUI difftool:
$ git pr show -t 13518

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13518.diff

Webrev

Link to Webrev Comment

Cleaning up and open sourcing three AWT tests

bridgekeeper · 2023-04-18T18:56:57Z

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-04-18T18:59:51Z

@azuev-java The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-04-18T19:04:18Z

Webrevs

lawrence-andrew · 2023-04-18T19:08:19Z

test/jdk/java/awt/Cursor/SingleColorCursorTest.java

+import java.awt.Toolkit;
+import java.awt.image.BufferedImage;
+import java.lang.reflect.InvocationTargetException;
+public class SingleColorCursorTest extends Panel {


Can you add empty line between class and the import statement

lawrence-andrew · 2023-04-18T19:11:50Z

All the 3 tests are new to open repo and there copy right years are different.

lawrence-andrew · 2023-04-18T20:04:19Z

test/jdk/java/awt/Dialog/DialogAsParentOfFileDialog.java

+        }
+    }
+
+    public static void main(String[] args) throws InterruptedException, InvocationTargetException {


Can you set to 80-column limit.

lawrence-andrew · 2023-04-18T20:09:42Z

test/jdk/java/awt/Dialog/ComponentShownEvent.java

+        }
+    }
+
+    public static void main(String[] args) throws InterruptedException, InvocationTargetException, AWTException {


Can you set to 80-column limit.

Now trying to keep the lines lengths reasonable.

lawrence-andrew · 2023-04-18T20:10:27Z

Set to 80-column limit where ever it required.

…shorter

openjdk · 2023-04-19T10:05:11Z

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306135: Clean up and open source some AWT tests

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

9fb53ad: 8305716: Enhancements for printing age tables
ebba42a: 8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message
42b7260: 8306111: PPC64: RT call after thaw with exception requires larger ABI section
c7faf60: 8305757: Call Method::compute_has_loops_flag() when creating CDS archive
eb8d8cd: 8299129: Enhance NameService lookups
77df315: 8296692: Improve String platform support
f098b49: 8298310: Enhance TLS session negotiation
9e56d10: 8296832: Improve Swing platform support
2e5700a: 8288436: Improve Xalan supports
b1c34c0: 8296684: Improve String platform support
... and 17 more: https://git.openjdk.org/jdk/compare/e3ece365ce7dc92dd9d0a7ad9eb53ed9ea87f48d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

azuev-java · 2023-04-19T16:54:52Z

/integrate

openjdk · 2023-04-19T16:56:14Z

Going to push as commit 4ad3ac6.
Since your change was applied there have been 34 commits pushed to the master branch:

85de01e: 8306323: Update license files in CLDR v43
48fd4f2: 8303431: [JVMCI] libgraal annotation API
c57af31: 8306038: SystemModulesPlugin generates code that doesn't pop when return value not used
a31a11f: 8306006: strace001.java fails due to unknown methods on stack
ddb8646: 8306123: Move InstanceKlass writeable flags
1a41e12: 8306310: Move is_shared Klass flag
c738c8e: 8306278: jvmtiAgentList.cpp:253 assert(offset >= 0) failed: invariant occurs on AIX after JDK-8257967
9fb53ad: 8305716: Enhancements for printing age tables
ebba42a: 8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message
42b7260: 8306111: PPC64: RT call after thaw with exception requires larger ABI section
... and 24 more: https://git.openjdk.org/jdk/compare/e3ece365ce7dc92dd9d0a7ad9eb53ed9ea87f48d...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-04-19T16:56:35Z

@azuev-java Pushed as commit 4ad3ac6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8306135: Clean up and open source some AWT tests

70d5b59

Cleaning up and open sourcing three AWT tests

openjdk bot added the rfr Pull request is ready for review label Apr 18, 2023

openjdk bot added the client client-libs-dev@openjdk.org label Apr 18, 2023

lawrence-andrew reviewed Apr 18, 2023

View reviewed changes

Added a line separating class declaration from imports

01c217f

lawrence-andrew reviewed Apr 18, 2023

View reviewed changes

azuev-java added 2 commits April 18, 2023 13:10

Cosmitic change: couple of extra-long strings were reformatted to be …

8877ee0

…shorter

Splitting couple of extra long lines to keep it more readable

2a04dff

azvegint approved these changes Apr 19, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 19, 2023

openjdk bot added the integrated Pull request has been integrated label Apr 19, 2023

openjdk bot closed this Apr 19, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2023

8306135: Clean up and open source some AWT tests #13518

8306135: Clean up and open source some AWT tests #13518

Uh oh!

Conversation

azuev-java commented Apr 18, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Apr 18, 2023

Uh oh!

openjdk bot commented Apr 18, 2023

Uh oh!

mlbridge bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

lawrence-andrew Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

azuev-java Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

lawrence-andrew commented Apr 18, 2023

Uh oh!

lawrence-andrew Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

azuev-java Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

lawrence-andrew Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

azuev-java Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

lawrence-andrew commented Apr 18, 2023

Uh oh!

openjdk bot commented Apr 19, 2023

Uh oh!

azuev-java commented Apr 19, 2023

Uh oh!

openjdk bot commented Apr 19, 2023

Uh oh!

openjdk bot commented Apr 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

azuev-java commented Apr 18, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 18, 2023 •

edited

Loading