8306408: Fix the format of several tables in building.md

[DingliZhang]

Hi all,

Currently, the format of several tables in building.md looks a little
problematic and will incorrectly display the split line. In contrast, the
corresponding building.html will display the tables correctly.

This patch will only change building.md and the format of the tables
will display correctly.

Please take a look and have some reviews. Thanks a lot.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306408: Fix the format of several tables in building.md

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13523/head:pull/13523
$ git checkout pull/13523

Update a local copy of the PR:
$ git checkout pull/13523
$ git pull https://git.openjdk.org/jdk.git pull/13523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13523

View PR using the GUI difftool:
$ git pr show -t 13523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13523.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DingliZhang The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (9c237f95)
• 02: Full - Incremental (aaf29afd)
• 01: Full - Incremental (37fd9f45)
• 00: Full (c3016531)

[erikj79]

I see we have this style of tables already present in building.md, so it should be fine. Generating building.html from this does cause a diff to the html file, so those still need to go in together. Please find a regenerated building.html in my branch here: https://github.com/erikj79/jdk/tree/JDK-8306408-regen-building.html

[DingliZhang]

I see we have this style of tables already present in building.md, so it should be fine. Generating building.html from this does cause a diff to the html file, so those still need to go in together. Please find a regenerated building.html in my branch here: https://github.com/erikj79/jdk/tree/JDK-8306408-regen-building.html

Thanks!

[DingliZhang]

Hi @erikj79
I apologize for a missing change. Could you please run pandoc again for me?
Thanks for your patience and help!

[erikj79]

Hi @erikj79 I apologize for a missing change. Could you please run pandoc again for me? Thanks for your patience and help!

Done.

[DingliZhang]

Hi @erikj79 I apologize for a missing change. Could you please run pandoc again for me? Thanks for your patience and help!

Done.

Thanks again!

[openjdk]

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306408: Fix the format of several tables in building.md

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• c6a288d: 8305945: (zipfs) Opening a directory to get input stream produces incorrect exception message
• 73018b3: 8306284: G1: Remove assertion in G1ScanHRForRegionClosure::do_claimed_block
• 33a7978: 8306538: Zero variant build failure after JDK-8257967
• 9c2e5b3: 8306459: s390x: Replace NULL to nullptr
• 6a7dff3: 8305880: Loom: Avoid putting stale object pointers in oops
• 310aa93: 8304291: [AIX] Broken build after JDK-8301998
• 64ed816: 8305943: Open source few AWT Focus related tests
• b8f0a66: 8041676: remove the java.compiler system property
• 781d6d7: 8306372: Open source AWT CardLayout and Checkbox tests
• d03128d: 8306280: Open source several choice AWT tests
• ... and 15 more: https://git.openjdk.org/jdk/compare/eb8d8cdddd10e4f586b37c00541e19c02f1e69a8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[DingliZhang]

Thanks for the review! @erikj79
/integrate

[openjdk]

@DingliZhang
Your change (at version 9c237f9) is now ready to be sponsored by a Committer.

[DingliZhang]

May I ask if anyone can sponsor for me? Thanks a lot!

[erikj79]

/sponsor

[openjdk]

Going to push as commit 26755a9.
Since your change was applied there have been 284 commits pushed to the master branch:

• 64c0962: 8307569: Build with gcc8 is broken after JDK-8307301
• bb3e44d: 8307603: [AIX] Broken build after JDK-8307301
• 5c7ede9: 8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS
• 89b7d07: 8307100: Remove ReferentBasedDiscovery reference discovery policy
• f6ea897: 8306285: Missing file in search test
• 33245d6: 8307517: Add VMErrorCallback infrastructure to extend hs_err dumping
• 7a1cb64: 8293547: Add relaxed add_and_fetch for macos aarch64 atomics
• 68f385c: 8307428: jstat tests doesn't tolerate dash in the O column
• 8bbd264: 8307423: [s390x] Represent Registers as values
• 959e62c: 8307521: Introduce check_oop infrastructure to check oops in the oop class
• ... and 274 more: https://git.openjdk.org/jdk/compare/eb8d8cdddd10e4f586b37c00541e19c02f1e69a8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 @DingliZhang Pushed as commit 26755a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.