Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306372: Open source AWT CardLayout and Checkbox tests #13543

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Apr 19, 2023

Moves to open some AWT tests, two for CardLayout and four for CheckBox


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306372: Open source AWT CardLayout and Checkbox tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13543/head:pull/13543
$ git checkout pull/13543

Update a local copy of the PR:
$ git checkout pull/13543
$ git pull https://git.openjdk.org/jdk.git pull/13543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13543

View PR using the GUI difftool:
$ git pr show -t 13543

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13543.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2023

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8306372 8306372: Open source AWT CardLayout and Checkbox tests Apr 19, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2023
@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 19, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306372: Open source AWT CardLayout and Checkbox tests

Reviewed-by: serb, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • fdb4baf: 8306134: Open source some AWT tests relating to Button and a few other classes
  • 4ad3ac6: 8306135: Clean up and open source some AWT tests
  • 85de01e: 8306323: Update license files in CLDR v43
  • 48fd4f2: 8303431: [JVMCI] libgraal annotation API
  • c57af31: 8306038: SystemModulesPlugin generates code that doesn't pop when return value not used
  • a31a11f: 8306006: strace001.java fails due to unknown methods on stack
  • ddb8646: 8306123: Move InstanceKlass writeable flags
  • 1a41e12: 8306310: Move is_shared Klass flag
  • c738c8e: 8306278: jvmtiAgentList.cpp:253 assert(offset >= 0) failed: invariant occurs on AIX after JDK-8257967
  • 9fb53ad: 8305716: Enhancements for printing age tables
  • ... and 16 more: https://git.openjdk.org/jdk/compare/0f3828dddd8d4a08677efcd15aa8dfde18540130...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 19, 2023
import java.awt.EventQueue;
import java.awt.Frame;

public class CheckboxCrashTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
public class CheckboxCrashTest {
public class CheckboxCrashTest {

System.out.println("chb2="+chb2);
System.out.println("gr.getSelectedCheckbox="+gr.getSelectedCheckbox());

if(chb1.getState()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(chb1.getState()
if (chb1.getState()

@prrace
Copy link
Contributor Author

prrace commented Apr 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 19, 2023

Going to push as commit 781d6d7.
Since your change was applied there have been 29 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2023
@openjdk openjdk bot closed this Apr 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2023
@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@prrace Pushed as commit 781d6d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants