8306543: GHA: MSVC installation is failing when component is already installed

[shipilev]

Currrent GHA fails on MSVC installation. Looks like the required versions are already installed in the runner image, and this is why the command fails. Our configure scripts look for the specific minor version, and the builds still pass if I drop the VC installation block completely. This tells me the appropriate minor version is already installed.

For safety, I think we can just ignore the errors from the MSVC installation. In case the runner images moves on to another minor version later, the dependencies would start to install successfully again.

See the GHA run. Both Windows x86_64 and Windows AArch64 select 1429~1.301:

* Toolchain:      microsoft (Microsoft Visual Studio 2019)
* C Compiler:     Version 19.29.30148 (at /c/progra~2/micros~2/2019/enterp~1/vc/tools/msvc/1429~1.301/bin/hostx64/x64/cl.exe)
* C++ Compiler:   Version 19.29.30148 (at /c/progra~2/micros~2/2019/enterp~1/vc/tools/msvc/1429~1.301/bin/hostx64/x64/cl.exe)

The last successful GHA run I had selected the same versions:

Tools summary:
* Toolchain:      microsoft (Microsoft Visual Studio 2019)
* C Compiler:     Version 19.29.30148 (at /c/progra~2/micros~2/2019/enterp~1/vc/tools/msvc/1429~1.301/bin/hostx64/x64/cl.exe)
* C++ Compiler:   Version 19.29.30148 (at /c/progra~2/micros~2/2019/enterp~1/vc/tools/msvc/1429~1.301/bin/hostx64/x64/cl.exe)

Additional testing:

• Ad-hoc GHA runs pass the configure/initial-build
• Full GHA runs pass (this PR)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306543: GHA: MSVC installation is failing when component is already installed

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13558/head:pull/13558
$ git checkout pull/13558

Update a local copy of the PR:
$ git checkout pull/13558
$ git pull https://git.openjdk.org/jdk.git pull/13558/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13558

View PR using the GUI difftool:
$ git pr show -t 13558

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13558.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d501fd40)

[shipilev]

Success! The only failing test is in x86_32 jdk/incubator/vector/ShortMaxVectorTests. Please review, I'd like to push this soon to provide GHA coverage on Windows.

[RealCLanger]

Looks good. Too bad that the Windows installer is not showing any sensible output.
We will want to backport this to 11u and 17u soon, too.

[shipilev]

Looks good. Too bad that the Windows installer is not showing any sensible output. We will want to backport this to 11u and 17u soon, too.

Yes, that would be my plan. GHA rolls out the new image right now, and so lots of backports are currently failing the testing.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306543: GHA: MSVC installation is failing when component is already installed

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• 20b1d19: 8305746: InitializeEncoding should cache Charset object instead of charset name
• 955abca: 8306483: (ch) Channels.newReader(ReadableByteChannel,Charset) refers to csName
• c6a288d: 8305945: (zipfs) Opening a directory to get input stream produces incorrect exception message
• 73018b3: 8306284: G1: Remove assertion in G1ScanHRForRegionClosure::do_claimed_block
• 33a7978: 8306538: Zero variant build failure after JDK-8257967
• 9c2e5b3: 8306459: s390x: Replace NULL to nullptr
• 6a7dff3: 8305880: Loom: Avoid putting stale object pointers in oops
• 310aa93: 8304291: [AIX] Broken build after JDK-8301998
• 64ed816: 8305943: Open source few AWT Focus related tests
• b8f0a66: 8041676: remove the java.compiler system property
• ... and 30 more: https://git.openjdk.org/jdk/compare/0f3828dddd8d4a08677efcd15aa8dfde18540130...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks for review, @RealCLanger!
Any other reviews, please, so I can push?

[RealCLanger]

Hm, I did some more testing... The actual error comes from the path in option --installPath in this line. Seems like the Windows installer now needs a path notation with backslash () instead of (/). If you correct that, the installation will work again. So that would be the more correct fix, I guess.

On the other hand, the installation takes some 5 to 15 minutes, for something that's obviously already available in the runner. I think we should tweak that and somehow check whether an installation is necessary beforehand at all.

[RealCLanger]

OK, yes, I believe I have a more correct solution to the issue. Will open a separate PR.

[RealCLanger]

See #13574

[shipilev]

Closed in favor of #13574.