Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296153: Bump minimum boot jdk to JDK 20 #13565

Closed
wants to merge 1 commit into from

Conversation

vidmik
Copy link
Contributor

@vidmik vidmik commented Apr 20, 2023

With the JDK 20 GA out it's time to bump the minimum boot JDK version for mainline/JDK 21.

Testing: tier1-5, GHA (the Windows build successfully downloads the JDK but then fails for unrelated reasons, and one seemingly unrelated Vector API test failure in tier 3)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13565/head:pull/13565
$ git checkout pull/13565

Update a local copy of the PR:
$ git checkout pull/13565
$ git pull https://git.openjdk.org/jdk.git pull/13565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13565

View PR using the GUI difftool:
$ git pr show -t 13565

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13565.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2023

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 20, 2023

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Apr 20, 2023
@vidmik vidmik changed the title Draft: 8296153: Bump minimum boot jdk to JDK 20 8296153: Bump minimum boot jdk to JDK 20 Apr 21, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296153: Bump minimum boot jdk to JDK 20

Reviewed-by: erikj, darcy, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • 117c5b1: 8279216: Investigate implementation of premultiplied alpha in the Little-CMS 2.13
  • 723037a: 8298048: Combine CDS archive heap into a single block
  • d518dbf: 8306440: Rename PSS:_num_optional_regions to _max_num_optional_regions
  • 9cd5741: 8306436: Rename PSS*:_n_workers to PSS*:_num_workers
  • 6e77e14: 8306456: Don't leak _worklist's memory in PhaseLive::compute
  • be6031b: 8303703: Add support of execution tests using virtual thread factory jtreg plugin
  • 5a00617: 8306543: GHA: MSVC installation is failing
  • 3da987a: 8306075: Micro-optimize Enum.hashCode
  • fdaabd6: 8306581: JVMCI tests failed when run with -XX:TypeProfileLevel=222 after JDK-8303431
  • 36ec05d: 8306430: Open source some AWT tests related to TextComponent and Toolkit
  • ... and 48 more: https://git.openjdk.org/jdk/compare/1b5d35ad2c8f0f3a43caba9d7a6d8e74f66caf5f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 21, 2023
@vidmik
Copy link
Contributor Author

vidmik commented Apr 21, 2023

Thank you for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

Going to push as commit cb158ff.
Since your change was applied there have been 58 commits pushed to the master branch:

  • 117c5b1: 8279216: Investigate implementation of premultiplied alpha in the Little-CMS 2.13
  • 723037a: 8298048: Combine CDS archive heap into a single block
  • d518dbf: 8306440: Rename PSS:_num_optional_regions to _max_num_optional_regions
  • 9cd5741: 8306436: Rename PSS*:_n_workers to PSS*:_num_workers
  • 6e77e14: 8306456: Don't leak _worklist's memory in PhaseLive::compute
  • be6031b: 8303703: Add support of execution tests using virtual thread factory jtreg plugin
  • 5a00617: 8306543: GHA: MSVC installation is failing
  • 3da987a: 8306075: Micro-optimize Enum.hashCode
  • fdaabd6: 8306581: JVMCI tests failed when run with -XX:TypeProfileLevel=222 after JDK-8303431
  • 36ec05d: 8306430: Open source some AWT tests related to TextComponent and Toolkit
  • ... and 48 more: https://git.openjdk.org/jdk/compare/1b5d35ad2c8f0f3a43caba9d7a6d8e74f66caf5f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 21, 2023
@openjdk openjdk bot closed this Apr 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 21, 2023
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@vidmik Pushed as commit cb158ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
4 participants