Skip to content

JDK-8306654: Disable NMT location_printing_cheap_dead_xx tests again#13575

Closed
tstuefe wants to merge 2 commits intoopenjdk:masterfrom
tstuefe:JDK-8306654-Disable-NMT-location_printing_cheap_dead_xx-tests-again
Closed

JDK-8306654: Disable NMT location_printing_cheap_dead_xx tests again#13575
tstuefe wants to merge 2 commits intoopenjdk:masterfrom
tstuefe:JDK-8306654-Disable-NMT-location_printing_cheap_dead_xx-tests-again

Conversation

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Apr 21, 2023

Trivial patch.

These tests show intermittent errors, see JDK-8306454. Disable them until we have time to investigate.

I originally wanted to remove them outright, but @dcubed-ojdk and @dholmes-ora were skeptical and that convinced me to retain them.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306654: Disable NMT location_printing_cheap_dead_xx tests again

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13575/head:pull/13575
$ git checkout pull/13575

Update a local copy of the PR:
$ git checkout pull/13575
$ git pull https://git.openjdk.org/jdk.git pull/13575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13575

View PR using the GUI difftool:
$ git pr show -t 13575

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13575.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2023
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@tstuefe To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@tstuefe tstuefe changed the title JDK-8306462: Remove NMT gtests that test dead-block-printing JDK-8306654: Disable NMT location_printing_cheap_dead_xx tests again Apr 21, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Apr 27, 2023

/label hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@tstuefe
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 27, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay on the disabling, but is there an issue filed to look into this further such that they can either be re-enabled or else confidently deleted?

Thanks.

@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306654: Disable NMT location_printing_cheap_dead_xx tests again

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 748476f: 8306732: TruncatedSeq::predict_next() attempts linear regression with only one data point
  • 27c5c10: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 9ebcda2: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
  • 1e4eafb: 8071693: Introspector ignores default interface methods
  • 750bece: 8305771: SA ClassWriter.java fails to skip overpass methods
  • b81c9c8: 8306951: [BACKOUT] JDK-8305252 make_method_handle_intrinsic may call java code under a lock
  • 732179c: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests
  • 38cc039: 8306705: com/sun/jdi/PopAndInvokeTest.java fails with NativeMethodException
  • 01b8512: 8302182: Update Public Suffix List to 88467c9
  • 8e36c05: 8305853: java/text/Format/DateFormat/DateFormatRegression.java fails with "Uncaught exception thrown in test method Test4089106"
  • ... and 32 more: https://git.openjdk.org/jdk/compare/07ea445b43e0df682f305c8709495094e807b1f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 27, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Apr 27, 2023

Okay on the disabling, but is there an issue filed to look into this further such that they can either be re-enabled or else confidently deleted?

Thanks.

Thank you David.

The issue is https://bugs.openjdk.org/browse/JDK-8306454.

@tstuefe
Copy link
Member Author

tstuefe commented Apr 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 27, 2023

Going to push as commit a83c02f.
Since your change was applied there have been 43 commits pushed to the master branch:

  • de0c05d: 6995195: Static initialization deadlock in sun.java2d.loops.Blit and GraphicsPrimitiveMgr
  • 748476f: 8306732: TruncatedSeq::predict_next() attempts linear regression with only one data point
  • 27c5c10: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 9ebcda2: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
  • 1e4eafb: 8071693: Introspector ignores default interface methods
  • 750bece: 8305771: SA ClassWriter.java fails to skip overpass methods
  • b81c9c8: 8306951: [BACKOUT] JDK-8305252 make_method_handle_intrinsic may call java code under a lock
  • 732179c: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests
  • 38cc039: 8306705: com/sun/jdi/PopAndInvokeTest.java fails with NativeMethodException
  • 01b8512: 8302182: Update Public Suffix List to 88467c9
  • ... and 33 more: https://git.openjdk.org/jdk/compare/07ea445b43e0df682f305c8709495094e807b1f8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 27, 2023
@openjdk openjdk bot closed this Apr 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@tstuefe Pushed as commit a83c02f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the JDK-8306654-Disable-NMT-location_printing_cheap_dead_xx-tests-again branch July 25, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants