JDK-8306654: Disable NMT location_printing_cheap_dead_xx tests again#13575
JDK-8306654: Disable NMT location_printing_cheap_dead_xx tests again#13575tstuefe wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
|
@tstuefe To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
…rinting_cheap_dead_xx-tests-again
|
/label hotspot-runtime |
|
@tstuefe |
dholmes-ora
left a comment
There was a problem hiding this comment.
Okay on the disabling, but is there an issue filed to look into this further such that they can either be re-enabled or else confidently deleted?
Thanks.
|
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you David. The issue is https://bugs.openjdk.org/browse/JDK-8306454. |
|
/integrate |
|
Going to push as commit a83c02f.
Your commit was automatically rebased without conflicts. |
Trivial patch.
These tests show intermittent errors, see JDK-8306454. Disable them until we have time to investigate.
I originally wanted to remove them outright, but @dcubed-ojdk and @dholmes-ora were skeptical and that convinced me to retain them.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13575/head:pull/13575$ git checkout pull/13575Update a local copy of the PR:
$ git checkout pull/13575$ git pull https://git.openjdk.org/jdk.git pull/13575/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13575View PR using the GUI difftool:
$ git pr show -t 13575Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13575.diff
Webrev
Link to Webrev Comment