8306543: GHA: MSVC installation is failing

[RealCLanger]

This is the plain fix for the currently observed error in GHA.

Will handle the optional install of the MSVC toolchain in a separate item.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306543: GHA: MSVC installation is failing

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13576/head:pull/13576
$ git checkout pull/13576

Update a local copy of the PR:
$ git checkout pull/13576
$ git pull https://git.openjdk.org/jdk.git pull/13576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13576

View PR using the GUI difftool:
$ git pr show -t 13576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13576.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (eec27db3)

[shipilev]

Okay, as long as GHAs are green after this change.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306543: GHA: MSVC installation is failing

Reviewed-by: shade, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 3da987a: 8306075: Micro-optimize Enum.hashCode
• fdaabd6: 8306581: JVMCI tests failed when run with -XX:TypeProfileLevel=222 after JDK-8303431
• 36ec05d: 8306430: Open source some AWT tests related to TextComponent and Toolkit
• 8346ae2: 8305942: Open source several AWT Focus related tests
• 9a68d1d: 8306060: Open source few AWT Insets related tests
• 2c70828: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051
• ffb2494: 8305207: Calendar.aggregateStamp(int, int) return value can be simplified
• 174c1a6: 4737887: (cal) API: Calendar methods taking field should document exceptions
• f633623: 8306474: Move InstanceKlass read-only flags
• afd2501: 8306482: Remove unused Method AccessFlags
• ... and 4 more: https://git.openjdk.org/jdk/compare/c6a288dcd63824230638f2d08a1372f1d6e16829...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

Okay, as long as GHAs are green after this change.

It already got past the installation step. 😄 Will wait until GHA is done and integrate if there are no new related issues.

[TheRealMDoerr]

LGTM.

[RealCLanger]

Thanks for the reviews. Now the GHAs are merely done with only some jtregs for Windows and MacOS not having finished yet. Should any of these fail, it's quite unlikely that they have to do with this change, same goes for the test error on linuxx86. So I'll integrate and trigger backports to unblock dev.

/integrate

[openjdk]

Going to push as commit 5a00617.
Since your change was applied there have been 14 commits pushed to the master branch:

• 3da987a: 8306075: Micro-optimize Enum.hashCode
• fdaabd6: 8306581: JVMCI tests failed when run with -XX:TypeProfileLevel=222 after JDK-8303431
• 36ec05d: 8306430: Open source some AWT tests related to TextComponent and Toolkit
• 8346ae2: 8305942: Open source several AWT Focus related tests
• 9a68d1d: 8306060: Open source few AWT Insets related tests
• 2c70828: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051
• ffb2494: 8305207: Calendar.aggregateStamp(int, int) return value can be simplified
• 174c1a6: 4737887: (cal) API: Calendar methods taking field should document exceptions
• f633623: 8306474: Move InstanceKlass read-only flags
• afd2501: 8306482: Remove unused Method AccessFlags
• ... and 4 more: https://git.openjdk.org/jdk/compare/c6a288dcd63824230638f2d08a1372f1d6e16829...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 5a00617.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.