Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one #13580

Closed
wants to merge 1 commit into from

Conversation

lkorinth
Copy link
Contributor

@lkorinth lkorinth commented Apr 21, 2023

Each garbage producer should have three test description each with different -ms flags. A mistake was made when this file was created (probably because the first byteArr test is named differently).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13580/head:pull/13580
$ git checkout pull/13580

Update a local copy of the PR:
$ git checkout pull/13580
$ git pull https://git.openjdk.org/jdk.git pull/13580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13580

View PR using the GUI difftool:
$ git pr show -t 13580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13580.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2023

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2023
@lkorinth
Copy link
Contributor Author

If you type rg -A1 ".*-gp .*Arr" --no-heading | sort in test/hotspot/jtreg/vmTestbase/gc/ArrayJuggle, you will spot the problem.

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@lkorinth The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 21, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one

Reviewed-by: tschatzl, lmesnik, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 95 new commits pushed to the master branch:

  • 6e77e14: 8306456: Don't leak _worklist's memory in PhaseLive::compute
  • be6031b: 8303703: Add support of execution tests using virtual thread factory jtreg plugin
  • 5a00617: 8306543: GHA: MSVC installation is failing
  • 3da987a: 8306075: Micro-optimize Enum.hashCode
  • fdaabd6: 8306581: JVMCI tests failed when run with -XX:TypeProfileLevel=222 after JDK-8303431
  • 36ec05d: 8306430: Open source some AWT tests related to TextComponent and Toolkit
  • 8346ae2: 8305942: Open source several AWT Focus related tests
  • 9a68d1d: 8306060: Open source few AWT Insets related tests
  • 2c70828: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051
  • ffb2494: 8305207: Calendar.aggregateStamp(int, int) return value can be simplified
  • ... and 85 more: https://git.openjdk.org/jdk/compare/0826ceee65ab83f643a77716f8f12d0060369923...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 21, 2023
@lkorinth
Copy link
Contributor Author

Thanks for your review!

@lkorinth
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

Going to push as commit ce493dd.
Since your change was applied there have been 106 commits pushed to the master branch:

  • f7d45b8: 8306076: Open source AWT misc tests
  • 4900517: 8306636: Disable compiler/c2/Test6905845.java with -XX:TieredStopAtLevel=3
  • 0f51e63: 8305590: Remove nothrow exception specifications from operator new
  • 8d696ae: 8306575: Clean up and open source four Dialog related tests
  • 9ed456f: 8306634: Open source AWT Event related tests
  • b2240bf: 8304696: Duplicate class names in dynamicArchive tests can lead to test failure
  • cb158ff: 8296153: Bump minimum boot jdk to JDK 20
  • 117c5b1: 8279216: Investigate implementation of premultiplied alpha in the Little-CMS 2.13
  • 723037a: 8298048: Combine CDS archive heap into a single block
  • d518dbf: 8306440: Rename PSS:_num_optional_regions to _max_num_optional_regions
  • ... and 96 more: https://git.openjdk.org/jdk/compare/0826ceee65ab83f643a77716f8f12d0060369923...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 24, 2023
@openjdk openjdk bot closed this Apr 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 24, 2023
@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@lkorinth Pushed as commit ce493dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
4 participants