8306652: Open source AWT MenuItem related tests #13589

kumarabhi006 · 2023-04-21T19:23:38Z

This PR is to open source MenuItem AWT tests.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8306652: Open source AWT MenuItem related tests

Reviewers

Phil Race (@prrace - Reviewer) ⚠️ Review applies to 3d07d952
Prasanta Sadhukhan (@prsadhuk - Reviewer) ⚠️ Review applies to 3d07d952

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13589/head:pull/13589
$ git checkout pull/13589

Update a local copy of the PR:
$ git checkout pull/13589
$ git pull https://git.openjdk.org/jdk.git pull/13589/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13589

View PR using the GUI difftool:
$ git pr show -t 13589

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13589.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-04-21T19:24:40Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-04-21T19:26:12Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-04-21T19:29:56Z

Webrevs

mrserb · 2023-04-21T21:08:51Z

test/jdk/java/awt/MenuItem/MenuSetLabelTest.java

+  @bug 4261935
+  @summary Menu display problem when changing the text of the menu(window 98)
+  @key headful
+  @run main/timeout=600 MenuSetLabelTest


Why the timeout is so big?

I have kept it as it was in the test before conversion.

Default timeout should work fine here, otherwise, we have a bug somewhere in this code.

Ok. Updated.

turbanoff · 2023-04-23T19:40:12Z

test/jdk/java/awt/MenuItem/MenuSetLabelTest.java

+    MenuBar mb1 = new MenuBar();
+    Menu f = new Menu(s1);
+    Menu m = new Menu(s1);
+    boolean  flag = true;


Suggested change

boolean flag = true;

boolean flag = true;

prrace · 2023-04-25T16:57:24Z

test/jdk/java/awt/MenuItem/EnableTest.java

+    public void start() throws Exception {
+        try {
+            EventQueue.invokeAndWait(() -> {
+                frame = new Frame();


Can we please have a meaningful Frame title here ? "EnableTest" perhaps ?

prrace · 2023-04-25T16:57:50Z

test/jdk/java/awt/MenuItem/MenuSetLabelTest.java

+    public void start() throws Exception {
+        try {
+            EventQueue.invokeAndWait(() -> {
+                f = new Menu1();


Menu1("MenuSetLabelTest")

prrace · 2023-04-25T16:58:15Z

test/jdk/java/awt/MenuItem/SetStateTest.java

+    public void start () throws Exception {
+        try {
+            EventQueue.invokeAndWait(() -> {
+                frame = new Frame();


Frame("SetStateTest")

kumarabhi006 · 2023-04-25T18:00:45Z

@prrace Frame title updated.

openjdk · 2023-04-25T18:11:01Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306652: Open source AWT MenuItem related tests

Reviewed-by: prr, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 84 new commits pushed to the master branch:

f3e8bd1: 8306755: Open source few Swing JComponent and AbstractButton tests
1c1a73f: 8302908: RISC-V: Support masked vector arithmetic instructions for Vector API
adf62fe: 8304918: Remove unused decl field from AnnotatedType implementations
00b1eac: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13
88d9ebf: 8306752: Open source several container and component AWT tests
1c2dadc: 8306683: Open source several clipboard and color AWT tests
b372f28: 8306753: Open source several container AWT tests
e3ccaa6: 8306623: (bf) CharBuffer::allocate throws unexpected exception type with some CharSequences
d819deb: 8304423: Refactor FdLibm.java
28829f3: 8306734: Shenandoah: Missing barriers on deoptimization path
... and 74 more: https://git.openjdk.org/jdk/compare/6a7dff30edce7a24400b27bee4d7ddd45eed523d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

prsadhuk · 2023-04-26T03:44:23Z

test/jdk/java/awt/MenuItem/MenuSetLabelTest.java

+        for (int i=0;i<5;i++)
+            m.add(new MenuItem(s3));
+        for (int i=0;i<10;i++)
+            f.add(new MenuItem(s3));


please add a space before and after operator as in i = 0 for all these

kumarabhi006 · 2023-04-26T05:16:26Z

/integrate

openjdk · 2023-04-26T05:18:03Z

Going to push as commit ed1ebd2.
Since your change was applied there have been 84 commits pushed to the master branch:

f3e8bd1: 8306755: Open source few Swing JComponent and AbstractButton tests
1c1a73f: 8302908: RISC-V: Support masked vector arithmetic instructions for Vector API
adf62fe: 8304918: Remove unused decl field from AnnotatedType implementations
00b1eac: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13
88d9ebf: 8306752: Open source several container and component AWT tests
1c2dadc: 8306683: Open source several clipboard and color AWT tests
b372f28: 8306753: Open source several container AWT tests
e3ccaa6: 8306623: (bf) CharBuffer::allocate throws unexpected exception type with some CharSequences
d819deb: 8304423: Refactor FdLibm.java
28829f3: 8306734: Shenandoah: Missing barriers on deoptimization path
... and 74 more: https://git.openjdk.org/jdk/compare/6a7dff30edce7a24400b27bee4d7ddd45eed523d...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-04-26T05:18:16Z

@kumarabhi006 Pushed as commit ed1ebd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Open source MenuItem AWT tests

798212c

openjdk bot added the rfr Pull request is ready for review label Apr 21, 2023

openjdk bot added the client client-libs-dev@openjdk.org label Apr 21, 2023

mrserb reviewed Apr 21, 2023

View reviewed changes

turbanoff reviewed Apr 23, 2023

View reviewed changes

kumarabhi006 added 2 commits April 25, 2023 11:53

Review comment update

3938116

Timeout removed

7b89b4e

prrace suggested changes Apr 25, 2023

View reviewed changes

Frame title set

3d07d95

prrace approved these changes Apr 25, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2023

prsadhuk approved these changes Apr 26, 2023

View reviewed changes

Space added

eeb29f1

openjdk bot added the integrated Pull request has been integrated label Apr 26, 2023

openjdk bot closed this Apr 26, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8306652: Open source AWT MenuItem related tests #13589

8306652: Open source AWT MenuItem related tests #13589

kumarabhi006 commented Apr 21, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 21, 2023

openjdk bot commented Apr 21, 2023

mlbridge bot commented Apr 21, 2023 •

edited

Loading

mrserb Apr 21, 2023

kumarabhi006 Apr 25, 2023

mrserb Apr 25, 2023

kumarabhi006 Apr 25, 2023

turbanoff Apr 23, 2023

prrace Apr 25, 2023

prrace Apr 25, 2023

prrace Apr 25, 2023

kumarabhi006 commented Apr 25, 2023

openjdk bot commented Apr 25, 2023 •

edited

Loading

prsadhuk Apr 26, 2023

kumarabhi006 commented Apr 26, 2023

openjdk bot commented Apr 26, 2023

openjdk bot commented Apr 26, 2023

8306652: Open source AWT MenuItem related tests #13589

8306652: Open source AWT MenuItem related tests #13589

Conversation

kumarabhi006 commented Apr 21, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 21, 2023

openjdk bot commented Apr 21, 2023

mlbridge bot commented Apr 21, 2023 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumarabhi006 commented Apr 25, 2023

openjdk bot commented Apr 25, 2023 • edited Loading

Choose a reason for hiding this comment

kumarabhi006 commented Apr 26, 2023

openjdk bot commented Apr 26, 2023

openjdk bot commented Apr 26, 2023

kumarabhi006 commented Apr 21, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 21, 2023 •

edited

Loading

openjdk bot commented Apr 25, 2023 •

edited

Loading